Fix storing ids in `Ui/Dialog` elements
authorMatthias Schmidt <gravatronics@live.com>
Fri, 6 Nov 2020 13:45:07 +0000 (14:45 +0100)
committerMatthias Schmidt <gravatronics@live.com>
Fri, 6 Nov 2020 13:45:07 +0000 (14:45 +0100)
See b6b1bdd4461e8a841b3d0aff02043aef5acceb3a

wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Dialog.js
wcfsetup/install/files/ts/WoltLabSuite/Core/Ui/Dialog.ts

index 01ed6e661c0d3a263d0c21ba2820d11fb971cd77..5d881c2d04db7b7563b56884f109744871106a1a 100644 (file)
@@ -290,7 +290,7 @@ define(["require", "exports", "tslib", "../Core", "../Dom/Change/Listener", "./S
             dialog.classList.add("dialogContainer");
             dialog.setAttribute("aria-hidden", "true");
             dialog.setAttribute("role", "dialog");
-            dialog.id = id;
+            dialog.dataset.id = id;
             const header = document.createElement("header");
             dialog.appendChild(header);
             const titleId = Util_1.default.getUniqueId();
index 203e47488d9216c5fc7c3f331d440a95aaef03a1..f7bbd7303156021cf697007482154cdda03e5134 100644 (file)
@@ -348,7 +348,7 @@ const UiDialog = {
     dialog.classList.add("dialogContainer");
     dialog.setAttribute("aria-hidden", "true");
     dialog.setAttribute("role", "dialog");
-    dialog.id = id;
+    dialog.dataset.id = id;
 
     const header = document.createElement("header");
     dialog.appendChild(header);