[PATCH] kthread: convert smbiod
authorSerge E. Hallyn <serue@us.ibm.com>
Sun, 25 Jun 2006 12:49:00 +0000 (05:49 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sun, 25 Jun 2006 17:01:21 +0000 (10:01 -0700)
Update smbiod to use kthread instead of deprecated kernel_thread.

[akpm@osdl.org: cleanup]
Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/smbfs/smbiod.c

index 481a97a423fa5270c1eaa6c2ae4b2db54ad24522..3f71384020cb8976962c8e1e3322810a36c579bf 100644 (file)
@@ -20,6 +20,7 @@
 #include <linux/smp_lock.h>
 #include <linux/module.h>
 #include <linux/net.h>
+#include <linux/kthread.h>
 #include <net/ip.h>
 
 #include <linux/smb_fs.h>
@@ -40,7 +41,7 @@ enum smbiod_state {
 };
 
 static enum smbiod_state smbiod_state = SMBIOD_DEAD;
-static pid_t smbiod_pid;
+static struct task_struct *smbiod_thread;
 static DECLARE_WAIT_QUEUE_HEAD(smbiod_wait);
 static LIST_HEAD(smb_servers);
 static DEFINE_SPINLOCK(servers_lock);
@@ -67,20 +68,29 @@ void smbiod_wake_up(void)
  */
 static int smbiod_start(void)
 {
-       pid_t pid;
+       struct task_struct *tsk;
+       int err = 0;
+
        if (smbiod_state != SMBIOD_DEAD)
                return 0;
        smbiod_state = SMBIOD_STARTING;
        __module_get(THIS_MODULE);
        spin_unlock(&servers_lock);
-       pid = kernel_thread(smbiod, NULL, 0);
-       if (pid < 0)
+       tsk = kthread_run(smbiod, NULL, "smbiod");
+       if (IS_ERR(tsk)) {
+               err = PTR_ERR(tsk);
                module_put(THIS_MODULE);
+       }
 
        spin_lock(&servers_lock);
-       smbiod_state = pid < 0 ? SMBIOD_DEAD : SMBIOD_RUNNING;
-       smbiod_pid = pid;
-       return pid;
+       if (err < 0) {
+               smbiod_state = SMBIOD_DEAD;
+               smbiod_thread = NULL;
+       } else {
+               smbiod_state = SMBIOD_RUNNING;
+               smbiod_thread = tsk;
+       }
+       return err;
 }
 
 /*
@@ -290,8 +300,6 @@ out:
  */
 static int smbiod(void *unused)
 {
-       daemonize("smbiod");
-
        allow_signal(SIGKILL);
 
        VERBOSE("SMB Kernel thread starting (%d) ...\n", current->pid);