clk: mediatek: fixed static checker warning in clk_cpumux_get_parent call
authorSean Wang <sean.wang@mediatek.com>
Mon, 17 Jul 2017 06:01:19 +0000 (14:01 +0800)
committerStephen Boyd <sboyd@codeaurora.org>
Tue, 18 Jul 2017 01:17:28 +0000 (18:17 -0700)
Fixed the signedness bug returning '(-22)' on the return type as u8 with
removing the sanity checker in clk_cpumux_get_parent() since
clk_cpumux_set_parent() always ensures validity in clk_cpumux_get_parent()
got called.

Fixes: 1e17de9049da ("clk: mediatek: add missing cpu mux causing Mediatek cpufreq can't work")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/mediatek/clk-cpumux.c

index edd8e6918050f3bdaa0a9bc8989be19d617d7f7d..347d7990b30f591e770c93e44f79be2bcbfb90f1 100644 (file)
@@ -27,7 +27,6 @@ static inline struct mtk_clk_cpumux *to_mtk_clk_cpumux(struct clk_hw *_hw)
 static u8 clk_cpumux_get_parent(struct clk_hw *hw)
 {
        struct mtk_clk_cpumux *mux = to_mtk_clk_cpumux(hw);
-       int num_parents = clk_hw_get_num_parents(hw);
        unsigned int val;
 
        regmap_read(mux->regmap, mux->reg, &val);
@@ -35,9 +34,6 @@ static u8 clk_cpumux_get_parent(struct clk_hw *hw)
        val >>= mux->shift;
        val &= mux->mask;
 
-       if (val >= num_parents)
-               return -EINVAL;
-
        return val;
 }