6lowpan: fix assignment of peer_addr
authorColin Ian King <colin.king@canonical.com>
Tue, 28 Mar 2017 12:11:29 +0000 (13:11 +0100)
committerMarcel Holtmann <marcel@holtmann.org>
Wed, 12 Apr 2017 20:02:39 +0000 (22:02 +0200)
The data from peer->chan->dst is not being copied to peer_addr, the
current code just updates the pointer and not the contents of what
it points to.  Fix this with the intended assignment.

Detected by CoverityScan, CID#1422111 ("Parse warning
(PW.PARAM_SET_BUT_NOT_USED)")

Fixes: fb6f2f606ce8 ("6lowpan: Fix IID format for Bluetooth")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/6lowpan.c

index 24348c8579dd7247586fd0782ef803bc0e972f62..ba28c7b1557fd1678ddbc950bb2feebc90cca9d5 100644 (file)
@@ -432,7 +432,7 @@ static int setup_header(struct sk_buff *skb, struct net_device *netdev,
                }
 
                daddr = peer->lladdr;
-               peer_addr = &peer->chan->dst;
+               *peer_addr = peer->chan->dst;
                *peer_addr_type = peer->chan->dst_type;
                lowpan_cb(skb)->chan = peer->chan;