PCI: xilinx: Fix xilinx_pcie_assign_msi() return value test

We should be testing "hwirq" instead of "irq".  "irq" is unsigned so it's
never less than zero.  Also it's uninitialized.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Srikanth Thokala <sthokal@xilinx.com>

diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c
index 44f894493dca8e2499eda7ebe89719739f030320..ccc496b33a9747f5e42a6172ecf1cf1088173dd5 100644 (file)
--- a/drivers/pci/host/pcie-xilinx.c
+++ b/drivers/pci/host/pcie-xilinx.c
@@ -359,8 +359,8 @@ static int xilinx_pcie_msi_setup_irq(struct msi_chip *chip,
        phys_addr_t msg_addr;
 
        hwirq = xilinx_pcie_assign_msi(port);
-       if (irq < 0)
-               return irq;
+       if (hwirq < 0)
+               return hwirq;
 
        irq = irq_create_mapping(port->irq_domain, hwirq);
        if (!irq)