[NETFILTER]: nf_queue: remove unused data pointer
authorPatrick McHardy <kaber@trash.net>
Wed, 5 Dec 2007 09:24:30 +0000 (01:24 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Jan 2008 22:56:10 +0000 (14:56 -0800)
Remove the data pointer from struct nf_queue_handler. It has never been used
and is useless for the only handler that really matters, nfnetlink_queue,
since the handler is shared between all instances.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netfilter.h
net/ipv4/netfilter/ip_queue.c
net/ipv6/netfilter/ip6_queue.c
net/netfilter/nf_queue.c
net/netfilter/nfnetlink_queue.c

index c2c3fafa5fd0071ac828ca961f06df12210a7320..1ba60112ab83a24820a8d4e4beea29b10c5aedc9 100644 (file)
@@ -277,8 +277,7 @@ int compat_nf_getsockopt(struct sock *sk, int pf, int optval,
 /* Packet queuing */
 struct nf_queue_handler {
        int (*outfn)(struct sk_buff *skb, struct nf_info *info,
-                    unsigned int queuenum, void *data);
-       void *data;
+                    unsigned int queuenum);
        char *name;
 };
 extern int nf_register_queue_handler(int pf,
index 062ff196f2c5789700f699808db00f337b92d8d7..08e7f8b4e95114c4e1eeffd529a5e3aab03d4570 100644 (file)
@@ -272,7 +272,7 @@ nlmsg_failure:
 
 static int
 ipq_enqueue_packet(struct sk_buff *skb, struct nf_info *info,
-                  unsigned int queuenum, void *data)
+                  unsigned int queuenum)
 {
        int status = -EINVAL;
        struct sk_buff *nskb;
index d6e971bd9fe110ce3fe80cc59a94458fea0e6443..5a9ca0d4fb2fa240de29b62c3bbd4247ffa59a6f 100644 (file)
@@ -269,7 +269,7 @@ nlmsg_failure:
 
 static int
 ipq_enqueue_packet(struct sk_buff *skb, struct nf_info *info,
-                  unsigned int queuenum, void *data)
+                  unsigned int queuenum)
 {
        int status = -EINVAL;
        struct sk_buff *nskb;
index dd18126a1a6d2cff38c2a2a3014dcff6c5baac6a..c098ccbbbcee524125f066b68feb6506b90df7b5 100644 (file)
@@ -153,7 +153,7 @@ static int __nf_queue(struct sk_buff *skb,
        }
 #endif
        afinfo->saveroute(skb, info);
-       status = qh->outfn(skb, info, queuenum, qh->data);
+       status = qh->outfn(skb, info, queuenum);
 
        rcu_read_unlock();
 
index b75091c8ae5ebdd057423729712161b4b2ab2d4b..94ec1c263d038fd5a91d298be57aed4c0e1eac14 100644 (file)
@@ -534,7 +534,7 @@ nla_put_failure:
 
 static int
 nfqnl_enqueue_packet(struct sk_buff *skb, struct nf_info *info,
-                    unsigned int queuenum, void *data)
+                    unsigned int queuenum)
 {
        int status = -EINVAL;
        struct sk_buff *nskb;