i40e: remove BUG_ON from FCoE setup
authorShannon Nelson <shannon.nelson@intel.com>
Wed, 21 Oct 2015 23:47:05 +0000 (19:47 -0400)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 25 Nov 2015 18:05:55 +0000 (10:05 -0800)
There's no need to kill the kernel thread here. If this condition was
true, the probe() would have died long before we got here. In any case,
we'll get the same result when this code tries to use the VSI pointer
being checked.

Prompted by a recent Linus diatribe.

Change-ID: I62f531cac34d4fc28ff9657d5b2d9523ae5e33a4
Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_fcoe.c

index fe5d9bf3ed6d80801f5881d47309af3b69ec01e4..579a46ca82dfa3bce548b7ae81527b064d7b1509 100644 (file)
@@ -1544,8 +1544,6 @@ void i40e_fcoe_vsi_setup(struct i40e_pf *pf)
        if (!(pf->flags & I40E_FLAG_FCOE_ENABLED))
                return;
 
-       BUG_ON(!pf->vsi[pf->lan_vsi]);
-
        for (i = 0; i < pf->num_alloc_vsi; i++) {
                vsi = pf->vsi[i];
                if (vsi && vsi->type == I40E_VSI_FCOE) {