dm-mpath-rdac: don't stomp on a requests transfer bit
authorAndrew Vasquez <andrew.vasquez@qlogic.com>
Mon, 27 Aug 2007 22:25:01 +0000 (15:25 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 27 Aug 2007 23:15:44 +0000 (16:15 -0700)
Without this, we get qla2xxx complaining about "ISP System Error".

What's happening here is the firmware is detecting a Xfer-ready from the
storage when in fact the data-direction for a mode-select should be a
write (DATA_OUT).

The following patch fixes the problem (typo). Verified by Brian, as
well.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Verified-by: Brian De Wolf <bldewolf@csupomona.edu>
Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/md/dm-mpath-rdac.c

index 8b776b8cb7f7029c6997d2e54e31076a5adc6f54..16b1613457750e990c131592ff4501d5f9de0724 100644 (file)
@@ -292,7 +292,7 @@ static struct request *get_rdac_req(struct rdac_handler *h,
        rq->end_io_data = h;
        rq->timeout = h->timeout;
        rq->cmd_type = REQ_TYPE_BLOCK_PC;
-       rq->cmd_flags = REQ_FAILFAST | REQ_NOMERGE;
+       rq->cmd_flags |= REQ_FAILFAST | REQ_NOMERGE;
        return rq;
 }