ALSA: drivers: constify snd_pcm_ops structures
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Fri, 18 Aug 2017 07:45:12 +0000 (13:15 +0530)
committerTakashi Iwai <tiwai@suse.de>
Sat, 19 Aug 2017 09:02:15 +0000 (11:02 +0200)
snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/drivers/aloop.c
sound/drivers/ml403-ac97cr.c

index 6e02ee03f1b6e817e056b44a3ece0e35d95d4a0b..135adb17703cc4992e127f9dc881db1b715206c4 100644 (file)
@@ -750,7 +750,7 @@ static int loopback_close(struct snd_pcm_substream *substream)
        return 0;
 }
 
-static struct snd_pcm_ops loopback_playback_ops = {
+static const struct snd_pcm_ops loopback_playback_ops = {
        .open =         loopback_open,
        .close =        loopback_close,
        .ioctl =        snd_pcm_lib_ioctl,
@@ -763,7 +763,7 @@ static struct snd_pcm_ops loopback_playback_ops = {
        .mmap =         snd_pcm_lib_mmap_vmalloc,
 };
 
-static struct snd_pcm_ops loopback_capture_ops = {
+static const struct snd_pcm_ops loopback_capture_ops = {
        .open =         loopback_open,
        .close =        loopback_close,
        .ioctl =        snd_pcm_lib_ioctl,
index d634e107885123c40251cc43ad83c9a90083f580..18fd12996cf70c2cb8480684429370c17cc80e3a 100644 (file)
@@ -759,7 +759,7 @@ static int snd_ml403_ac97cr_capture_close(struct snd_pcm_substream *substream)
        return 0;
 }
 
-static struct snd_pcm_ops snd_ml403_ac97cr_playback_ops = {
+static const struct snd_pcm_ops snd_ml403_ac97cr_playback_ops = {
        .open = snd_ml403_ac97cr_playback_open,
        .close = snd_ml403_ac97cr_playback_close,
        .ioctl = snd_pcm_lib_ioctl,
@@ -770,7 +770,7 @@ static struct snd_pcm_ops snd_ml403_ac97cr_playback_ops = {
        .pointer = snd_ml403_ac97cr_pcm_pointer,
 };
 
-static struct snd_pcm_ops snd_ml403_ac97cr_capture_ops = {
+static const struct snd_pcm_ops snd_ml403_ac97cr_capture_ops = {
        .open = snd_ml403_ac97cr_capture_open,
        .close = snd_ml403_ac97cr_capture_close,
        .ioctl = snd_pcm_lib_ioctl,