mwifiex: wake up main thread to handle Tx traffic if scan is delayed/aborted
authorAmitkumar Karwar <akarwar@marvell.com>
Thu, 21 Jun 2012 02:58:36 +0000 (19:58 -0700)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 22 Jun 2012 18:44:04 +0000 (14:44 -0400)
This is a flaw in recently implemented logic to handle Tx traffic
and scan operation simultaneously. We missed to wakeup main thread
to handle Tx traffic if scan is delayed/aborted.

For some cards (SD8797, for example), firmware will send SLEEP event
if there is no activity for 50msec. While handling the SLEEP event,
main thread will be woken up and Tx packet gets sent hence. In worst
case Tx traffic will be delayed for 50msec.

For other cards, such as USB8797, firmware won't send SLEEP event.
So, Tx traffic gets stuck if no other event triggers the wakeup of
main thread.

This patch fixes above issues.

Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/mwifiex/init.c
drivers/net/wireless/mwifiex/main.c

index 0f18ef6a30c813d716f4cacd2bf65ba68a1515e3..b543a4d82ff3c64114892e13f758aa4d7db7abf2 100644 (file)
@@ -103,6 +103,7 @@ static void scan_delay_timer_fn(unsigned long data)
                                  msecs_to_jiffies(MWIFIEX_SCAN_DELAY_MSEC));
                        adapter->scan_delay_cnt++;
                }
+               queue_work(priv->adapter->workqueue, &priv->adapter->main_work);
        } else {
                /*
                 * Tx data queue is empty. Get scan command from scan_pending_q
index 0f06f07a70e67d7b3d76d12bcfdcab203cf29d3a..f0219efc895386bf8f507ec8a64e94809d17c743 100644 (file)
@@ -190,7 +190,8 @@ process_start:
                            adapter->tx_lock_flag)
                                break;
 
-                       if (adapter->scan_processing || adapter->data_sent ||
+                       if ((adapter->scan_processing &&
+                            !adapter->scan_delay_cnt) || adapter->data_sent ||
                            mwifiex_wmm_lists_empty(adapter)) {
                                if (adapter->cmd_sent || adapter->curr_cmd ||
                                    (!is_command_pending(adapter)))