USB: PCI-quirks: Deletion of unnecessary checks before the function call "pci_dev_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 21 Nov 2014 14:20:12 +0000 (15:20 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Nov 2014 01:24:31 +0000 (17:24 -0800)
The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/pci-quirks.c

index 2f3acebb577ae749aa6c8c23b0e592076b296e6c..dd483c13565bb7bbedc561d6e39fccee1477c279 100644 (file)
@@ -233,10 +233,8 @@ commit:
 
                spin_unlock_irqrestore(&amd_lock, flags);
 
-               if (info.nb_dev)
-                       pci_dev_put(info.nb_dev);
-               if (info.smbus_dev)
-                       pci_dev_put(info.smbus_dev);
+               pci_dev_put(info.nb_dev);
+               pci_dev_put(info.smbus_dev);
 
        } else {
                /* no race - commit the result */
@@ -447,10 +445,8 @@ void usb_amd_dev_put(void)
 
        spin_unlock_irqrestore(&amd_lock, flags);
 
-       if (nb)
-               pci_dev_put(nb);
-       if (smbus)
-               pci_dev_put(smbus);
+       pci_dev_put(nb);
+       pci_dev_put(smbus);
 }
 EXPORT_SYMBOL_GPL(usb_amd_dev_put);