mfd: asic3: Be sure to clamp return value
authorLinus Walleij <linus.walleij@linaro.org>
Tue, 22 Dec 2015 14:47:05 +0000 (15:47 +0100)
committerLee Jones <lee.jones@linaro.org>
Thu, 14 Jan 2016 08:43:43 +0000 (08:43 +0000)
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Paul Parsons <lost.distance@yahoo.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/asic3.c

index a726f01e3b026931bdf782dd8e00f2838c8d66a3..73812eedeefbca24d1c2a5dcfd12fdab62d1c5e9 100644 (file)
@@ -502,7 +502,8 @@ static int asic3_gpio_get(struct gpio_chip *chip,
                return -EINVAL;
        }
 
-       return asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS) & mask;
+       return !!(asic3_read_register(asic,
+                                     gpio_base + ASIC3_GPIO_STATUS) & mask);
 }
 
 static void asic3_gpio_set(struct gpio_chip *chip,