crypto: sahara - set nb_[in|out]_sg as signed int
authorLABBE Corentin <clabbe.montjoie@gmail.com>
Thu, 19 Nov 2015 12:38:17 +0000 (13:38 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Mon, 23 Nov 2015 12:55:55 +0000 (20:55 +0800)
The two unsigned int variables nb_in_sg and nb_out_sg can be assigned
signed value (-EINVAL) from sg_nents_for_len().
Furthermore they are used only by dma_map_sg and dma_unmap_sg which wait
for an signed int, so they must be set as int.

Fixes: 6c2b74d4774f ("crypto: sahara - check return value of sg_nents_for_len")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/sahara.c

index ea9f56a40d5a0caeda9703b22ca07b467c83b231..cc738f3592a3ba6397d4cd63e891d8f6c3b79958 100644 (file)
@@ -228,9 +228,9 @@ struct sahara_dev {
 
        size_t                  total;
        struct scatterlist      *in_sg;
-       unsigned int            nb_in_sg;
+       int             nb_in_sg;
        struct scatterlist      *out_sg;
-       unsigned int            nb_out_sg;
+       int             nb_out_sg;
 
        u32                     error;
 };