kmemcheck: use kmemcheck_pte_lookup() instead of open-coding it
authorPekka Enberg <penberg@cs.helsinki.fi>
Thu, 26 Feb 2009 09:53:11 +0000 (11:53 +0200)
committerVegard Nossum <vegard.nossum@gmail.com>
Mon, 15 Jun 2009 10:40:00 +0000 (12:40 +0200)
Lets use kmemcheck_pte_lookup() in kmemcheck_fault() instead of
open-coding it there.

Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
arch/x86/mm/kmemcheck/kmemcheck.c

index a644f248451bf61d33d46c90e0933dd45e0e8dc6..6931e5115bcd1a2544e6be684915278dd12a90d2 100644 (file)
@@ -611,7 +611,6 @@ bool kmemcheck_fault(struct pt_regs *regs, unsigned long address,
        unsigned long error_code)
 {
        pte_t *pte;
-       unsigned int level;
 
        /*
         * XXX: Is it safe to assume that memory accesses from virtual 86
@@ -624,13 +623,9 @@ bool kmemcheck_fault(struct pt_regs *regs, unsigned long address,
        if (regs->cs != __KERNEL_CS)
                return false;
 
-       pte = lookup_address(address, &level);
+       pte = kmemcheck_pte_lookup(address);
        if (!pte)
                return false;
-       if (level != PG_LEVEL_4K)
-               return false;
-       if (!pte_hidden(*pte))
-               return false;
 
        if (error_code & 2)
                kmemcheck_access(regs, address, KMEMCHECK_WRITE);