[SCSI] ibmvfc: Properly set cancel flags when cancelling abort
authorBrian King <brking@linux.vnet.ibm.com>
Fri, 12 Apr 2013 13:25:15 +0000 (08:25 -0500)
committerJames Bottomley <JBottomley@Parallels.com>
Thu, 2 May 2013 18:50:23 +0000 (11:50 -0700)
The flags on a cancel operation are intended to indicate what,
if any, TMF will follow the cancel request. This fixes a case
where we were incorrectly setting the abort task set flag on
the cancel flag when we were cancelling an abort task set.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Acked-by: Robert Jennings <rcj@linux.vnet.ibm.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/ibmvscsi/ibmvfc.c

index cc82d0f322b6cb30fd3fdaf1fd5e49665302dece..e652620707495881a4e50f638d6594208e9c53b7 100644 (file)
@@ -2327,7 +2327,7 @@ static int ibmvfc_abort_task_set(struct scsi_device *sdev)
        timeout = wait_for_completion_timeout(&evt->comp, timeout);
 
        if (!timeout) {
-               rc = ibmvfc_cancel_all(sdev, IBMVFC_TMF_ABORT_TASK_SET);
+               rc = ibmvfc_cancel_all(sdev, 0);
                if (!rc) {
                        rc = ibmvfc_wait_for_ops(vhost, sdev->hostdata, ibmvfc_match_key);
                        if (rc == SUCCESS)