genetlink: pass only network namespace to genl_has_listeners()
authorJohannes Berg <johannes.berg@intel.com>
Mon, 22 Dec 2014 17:56:36 +0000 (18:56 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 27 Dec 2014 07:20:23 +0000 (02:20 -0500)
There's no point to force the caller to know about the internal
genl_sock to use inside struct net, just have them pass the network
namespace. This doesn't really change code generation since it's
an inline, but makes the caller less magic - there's never any
reason to pass another socket.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/genetlink.h
net/openvswitch/datapath.c

index af10c2cf8a1dce00d9cc5414f67d5917bf911570..38620da4aa7a5b1d53892ade0f87961b7ccad0ad 100644 (file)
@@ -395,11 +395,11 @@ static inline int genl_set_err(struct genl_family *family, struct net *net,
 }
 
 static inline int genl_has_listeners(struct genl_family *family,
-                                    struct sock *sk, unsigned int group)
+                                    struct net *net, unsigned int group)
 {
        if (WARN_ON_ONCE(group >= family->n_mcgrps))
                return -EINVAL;
        group = family->mcgrp_offset + group;
-       return netlink_has_listeners(sk, group);
+       return netlink_has_listeners(net->genl_sock, group);
 }
 #endif /* __NET_GENERIC_NETLINK_H */
index 332b5a0317392002a18b86dadfd4671e18fb6896..4e9a5f035cbcf144998ae7c22c90151429cf7031 100644 (file)
@@ -83,8 +83,7 @@ static bool ovs_must_notify(struct genl_family *family, struct genl_info *info,
                            unsigned int group)
 {
        return info->nlhdr->nlmsg_flags & NLM_F_ECHO ||
-              genl_has_listeners(family, genl_info_net(info)->genl_sock,
-                                 group);
+              genl_has_listeners(family, genl_info_net(info), group);
 }
 
 static void ovs_notify(struct genl_family *family,