drm/i915/userptr: Remove superfluous interruptible=false on waiting
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 5 Aug 2016 09:14:09 +0000 (10:14 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 5 Aug 2016 09:54:36 +0000 (10:54 +0100)
Inside the kthread context, we can't be interrupted by signals so
touching the mm.interruptible flag is pointless and wait-request now
consumes EIO itself.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470388464-28458-4-git-send-email-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_gem_userptr.c

index 96ab6161903a28679be4124813825035a3918592..57218cca7e055b64b35ad0f9699e2776061e5322 100644 (file)
@@ -84,16 +84,9 @@ static void cancel_userptr(struct work_struct *work)
        obj->userptr.work = NULL;
 
        if (obj->pages != NULL) {
-               struct drm_i915_private *dev_priv = to_i915(dev);
-               bool was_interruptible;
-
-               was_interruptible = dev_priv->mm.interruptible;
-               dev_priv->mm.interruptible = false;
-
+               /* We are inside a kthread context and can't be interrupted */
                WARN_ON(i915_gem_object_unbind(obj));
                WARN_ON(i915_gem_object_put_pages(obj));
-
-               dev_priv->mm.interruptible = was_interruptible;
        }
 
        i915_gem_object_put(obj);