tipc: Add check to prevent insertion of duplicate name table entries

Adds a new check to TIPC's name table logic to reject any attempt to
create a new name publication that is identical to an existing one.
(Such an attempt will never happen under normal circumstances, but
could arise if another network node malfunctions and issues a duplicate
name publication message.)

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c
index 1196f050e334b8ecfd531afdf27e47a3bda5e950..c2224f98e64fa50a82cadfac684bc8b0c06a66ab 100644 (file)
--- a/net/tipc/name_table.c
+++ b/net/tipc/name_table.c
@@ -268,6 +268,13 @@ static struct publication *tipc_nameseq_insert_publ(struct name_seq *nseq,
                }
 
                info = sseq->info;
+
+               /* Check if an identical publication already exists */
+               list_for_each_entry(publ, &info->zone_list, zone_list) {
+                       if ((publ->ref == port) && (publ->key == key) &&
+                           (!publ->node || (publ->node == node)))
+                               return NULL;
+               }
        } else {
                u32 inspos;
                struct sub_seq *freesseq;