drm/ast: Delete an unnecessary check before drm_gem_object_unreference_unlocked()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 16 Jul 2016 07:54:22 +0000 (09:54 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 18 Jul 2016 07:11:32 +0000 (09:11 +0200)
The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/f28c063f-ec56-e62b-9370-89ce833fa4e5@users.sourceforge.net
drivers/gpu/drm/ast/ast_main.c

index 7bc3aa6dda8cff86f78ec0400bac76d852ebec95..904beaa932d03f0b5ce7d89a13d16729582052e0 100644 (file)
@@ -295,9 +295,8 @@ static int ast_get_dram_info(struct drm_device *dev)
 static void ast_user_framebuffer_destroy(struct drm_framebuffer *fb)
 {
        struct ast_framebuffer *ast_fb = to_ast_framebuffer(fb);
-       if (ast_fb->obj)
-               drm_gem_object_unreference_unlocked(ast_fb->obj);
 
+       drm_gem_object_unreference_unlocked(ast_fb->obj);
        drm_framebuffer_cleanup(fb);
        kfree(fb);
 }