tcp: fix validation of D-SACK
authorZheng Yan <zheng.z.yan@intel.com>
Mon, 19 Sep 2011 02:37:34 +0000 (22:37 -0400)
committerDavid S. Miller <davem@davemloft.net>
Mon, 19 Sep 2011 02:37:34 +0000 (22:37 -0400)
D-SACK is allowed to reside below snd_una. But the corresponding check
in tcp_is_sackblock_valid() is the exact opposite. It looks like a typo.

Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_input.c

index ea0d2183df4bc7f862fdf25eff2c74483880f26a..21fab3edb92cde6bbbbb8aff46b09db948ca8b6f 100644 (file)
@@ -1124,7 +1124,7 @@ static int tcp_is_sackblock_valid(struct tcp_sock *tp, int is_dsack,
                return 0;
 
        /* ...Then it's D-SACK, and must reside below snd_una completely */
-       if (!after(end_seq, tp->snd_una))
+       if (after(end_seq, tp->snd_una))
                return 0;
 
        if (!before(start_seq, tp->undo_marker))