projects
/
GitHub
/
MotorolaMobilityLLC
/
kernel-slsi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b2e5411
)
hwmon: (ltc2945) Don't crash the kernel unnecessarily
author
Guenter Roeck
<linux@roeck-us.net>
Mon, 21 Apr 2014 17:38:08 +0000
(10:38 -0700)
committer
Guenter Roeck
<linux@roeck-us.net>
Thu, 24 Apr 2014 13:09:43 +0000
(06:09 -0700)
An implementation error should not crash the kernel if it is avoidable.
Replace BUG() with WARN_ONCE().
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ltc2945.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/hwmon/ltc2945.c
b/drivers/hwmon/ltc2945.c
index c104cc32989df7af8ce972b6a5803dfdf5dbaf61..c9cddf5f056bbd6fe014dbd6dfc8dc25eac949d6 100644
(file)
--- a/
drivers/hwmon/ltc2945.c
+++ b/
drivers/hwmon/ltc2945.c
@@
-1,4
+1,4
@@
-/*
+
/*
* Driver for Linear Technology LTC2945 I2C Power Monitor
*
* Copyright (c) 2014 Guenter Roeck
@@
-314,8
+314,8
@@
static ssize_t ltc2945_reset_history(struct device *dev,
reg = LTC2945_MAX_ADIN_H;
break;
default:
-
BUG(
);
-
break
;
+
WARN_ONCE(1, "Bad register: 0x%x\n", reg
);
+
return -EINVAL
;
}
/* Reset maximum */
ret = regmap_bulk_write(regmap, reg, buf_max, num_regs);