Apply suggestions from code review

Use explicit comparison
See #2825

Co-Authored-By: joshuaruesweg <josh@wcflabs.de>

diff --git a/wcfsetup/install/files/lib/action/AJAXFileUploadAction.class.php b/wcfsetup/install/files/lib/action/AJAXFileUploadAction.class.php
index b43a9caa922f3ffe7d84d60105f9c790d5d46d4c..d827cc0ed68a5636ecb6bbdd51e3b4826daee8a5 100644 (file)
--- a/wcfsetup/install/files/lib/action/AJAXFileUploadAction.class.php
+++ b/wcfsetup/install/files/lib/action/AJAXFileUploadAction.class.php
@@ -121,7 +121,7 @@ class AJAXFileUploadAction extends AbstractSecureAction {
                                'filename' => $file->getFilename(),
                                'icon' => $file->getIconName(),
                                'filesize' => FileUtil::formatFilesize($file->filesize),
-                               'image' => ($file->viewableImage) ? $file->getImage() : null, 
+                               'image' => $file->viewableImage ? $file->getImage() : null, 
                                'uniqueFileId' => $file->getUniqueFileId()
                        ];
                }

diff --git a/wcfsetup/install/files/lib/system/file/upload/UploadHandler.class.php b/wcfsetup/install/files/lib/system/file/upload/UploadHandler.class.php
index 9dafd645ab50bece9d5cb2fdfa970473d9c4eb09..2515b11847f3e7204eeaf86ab9223f5763f76e2b 100644 (file)
--- a/wcfsetup/install/files/lib/system/file/upload/UploadHandler.class.php
+++ b/wcfsetup/install/files/lib/system/file/upload/UploadHandler.class.php
@@ -137,7 +137,7 @@ class UploadHandler extends SingletonFactory {
                
                /** @var UploadFile $storageFile */
                foreach ($storage[$internalId]['files'] as $id => $storageFile) {
-                       if ($storageFile->getUniqueFileId() == $uniqueFileId) {
+                       if ($storageFile->getUniqueFileId() === $uniqueFileId) {
                                unset($storage[$internalId]['files'][$id]);
                                break;
                        }
@@ -195,7 +195,7 @@ class UploadHandler extends SingletonFactory {
                }
                
                foreach ($this->getFilesForInternalId($internalId) as $file) {
-                       if ($file->getUniqueFileId() == $uniqueFileId) {
+                       if ($file->getUniqueFileId() === $uniqueFileId) {
                                return $file;
                        }
                }