Incorrect checkbox behavior
authorAlexander Ebert <ebert@woltlab.com>
Tue, 4 Jan 2022 14:12:07 +0000 (15:12 +0100)
committerAlexander Ebert <ebert@woltlab.com>
Tue, 4 Jan 2022 14:12:07 +0000 (15:12 +0100)
com.woltlab.wcf/package.xml
ts/WoltLabSuite/Core/Acp/Ui/Package/Update/Manager.ts
wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Package/Update/Manager.js
wcfsetup/install/files/lib/system/WCF.class.php

index dac30a57bff3a333d9843061c34ac93bfb7e06e8..32eca1573222b9c0271298afcb7f8aa0f3e7636e 100644 (file)
@@ -5,7 +5,7 @@
                <packagedescription>Free CMS and web-framework, designed for awesome websites and communities.</packagedescription>
                <packagedescription language="de">Freies CMS und Web-Framework, das eindrucksvolle Websites und Communities ermöglicht.</packagedescription>
                <isapplication>1</isapplication>
-               <version>5.4.0</version>
+               <version>5.5.0 Alpha 1</version>
                <date>2021-12-22</date>
        </packageinformation>
        
index f1ab6edd32a83983daf737190a0b81b40ed574f6..88cd0313cf7e02f4bf75b8aebec0ea6df00c93f5 100644 (file)
@@ -62,14 +62,14 @@ class AcpUiPackageUpdateManager implements DialogCallbackObject {
   }
 
   private updateSubmitButtonState(): void {
-    let isValid = true;
+    let disableButton = true;
     this.packages.forEach((checkbox) => {
-      if (checkbox && !checkbox.checked) {
-        isValid = false;
+      if (!checkbox || checkbox.checked) {
+        disableButton = false;
       }
     });
 
-    this.submitButton.disabled = !isValid;
+    this.submitButton.disabled = disableButton;
   }
 
   private getSelectedPackages(): Record<string, string> {
index 07d995d188c8f3c7159ff45ac1d8bd009ed3647c..0313de15f253a95fe94b7f7ab304b392db82f4cb 100644 (file)
@@ -23,13 +23,13 @@ define(["require", "exports", "tslib", "../../../../Ajax", "../../../../Language
             });
         }
         updateSubmitButtonState() {
-            let isValid = true;
+            let disableButton = true;
             this.packages.forEach((checkbox) => {
-                if (checkbox && !checkbox.checked) {
-                    isValid = false;
+                if (!checkbox || checkbox.checked) {
+                    disableButton = false;
                 }
             });
-            this.submitButton.disabled = !isValid;
+            this.submitButton.disabled = disableButton;
         }
         getSelectedPackages() {
             const packages = {};
index 20e8494a8558d18131152db2c7e1f35bca07e5d7..3e47fcee7613466ec8fd4890b84aa9aec8aafeac 100644 (file)
@@ -53,7 +53,7 @@ if (!@\ini_get('date.timezone')) {
 }
 
 // define current woltlab suite version
-\define('WCF_VERSION', '5.4.0');
+\define('WCF_VERSION', '5.5.0 Alpha 1');
 
 // define current API version
 // @deprecated 5.2