lightnvm: pblk: simplify meta. memory allocation

smeta size will always be suitable for a kmalloc allocation. Simplify
the code and leave the vmalloc fallback only for emeta, where the pblk
configuration has an impact.

Signed-off-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <matias@cnexlabs.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index 29565f89a85e0a48e06d4b9dcd9c95d2821d2200..b5f7f3f191054f688fdcd0aa591e1ee14a8d5d33 100644 (file)
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -665,7 +665,8 @@ next_rq:
        }
        reinit_completion(&wait);
 
-       bio_put(bio);
+       if (likely(pblk->l_mg.emeta_alloc_type == PBLK_VMALLOC_META))
+               bio_put(bio);
 
        if (rqd.error) {
                if (dir == WRITE)

diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index cd10f2d74cf9fada3966df065ae70fb3c1ef2a56..a9115ff9555fd651aa8e9504f6c4dcb65beaa482 100644 (file)
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -355,9 +355,9 @@ static void pblk_line_meta_free(struct pblk *pblk)
        kfree(l_mg->vsc_list);
 
        for (i = 0; i < PBLK_DATA_LINES; i++) {
-               pblk_mfree(&l_mg->sline_meta[i], l_mg->smeta_alloc_type);
+               kfree(l_mg->sline_meta[i]);
                pblk_mfree(l_mg->eline_meta[i]->buf, l_mg->emeta_alloc_type);
-               kfree(&l_mg->eline_meta[i]);
+               kfree(l_mg->eline_meta[i]);
        }
 
        kfree(pblk->lines);
@@ -550,7 +550,6 @@ static int pblk_lines_alloc_metadata(struct pblk *pblk)
        /* smeta is always small enough to fit on a kmalloc memory allocation,
         * emeta depends on the number of LUNs allocated to the pblk instance
         */
-       l_mg->smeta_alloc_type = PBLK_KMALLOC_META;
        for (i = 0; i < PBLK_DATA_LINES; i++) {
                l_mg->sline_meta[i] = kmalloc(lm->smeta_len, GFP_KERNEL);
                if (!l_mg->sline_meta[i])
@@ -604,12 +603,12 @@ static int pblk_lines_alloc_metadata(struct pblk *pblk)
 fail_free_emeta:
        while (--i >= 0) {
                vfree(l_mg->eline_meta[i]->buf);
-               kfree(&l_mg->eline_meta[i]);
+               kfree(l_mg->eline_meta[i]);
        }
 
 fail_free_smeta:
        for (i = 0; i < PBLK_DATA_LINES; i++)
-               pblk_mfree(&l_mg->sline_meta[i], l_mg->smeta_alloc_type);
+               kfree(l_mg->sline_meta[i]);
 
        return -ENOMEM;
 }

diff --git a/drivers/lightnvm/pblk-write.c b/drivers/lightnvm/pblk-write.c
index a29a34786ac564a62c1441bfe36fe9d1060576a1..3db2cbe5b788ff5891524d5d7a530dfadb161c71 100644 (file)
--- a/drivers/lightnvm/pblk-write.c
+++ b/drivers/lightnvm/pblk-write.c
@@ -442,7 +442,8 @@ fail_rollback:
        list_add(&meta_line->list, &meta_line->list);
        spin_unlock(&l_mg->close_lock);
 fail_free_bio:
-       bio_put(bio);
+       if (likely(l_mg->emeta_alloc_type == PBLK_VMALLOC_META))
+               bio_put(bio);
 fail_free_rqd:
        pblk_free_rqd(pblk, rqd, READ);
        return ret;

diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h
index 6dc58d360077e62106d22dbf4d16b3478f0858e0..3fe8b05e3de01b886c54c0b19e09459250dc943f 100644 (file)
--- a/drivers/lightnvm/pblk.h
+++ b/drivers/lightnvm/pblk.h
@@ -446,7 +446,6 @@ struct pblk_line_mgmt {
        __le32 *vsc_list;               /* Valid sector counts for all lines */
 
        /* Metadata allocation type: VMALLOC | KMALLOC */
-       int smeta_alloc_type;
        int emeta_alloc_type;
 
        /* Pre-allocated metadata for data lines */