KEYS: testing wrong bit for KEY_FLAG_REVOKED

The test for "if (cred->request_key_auth->flags & KEY_FLAG_REVOKED) {"
should actually testing that the (1 << KEY_FLAG_REVOKED) bit is set.
The current code actually checks for KEY_FLAG_DEAD.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>

diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
index 1068cb1939b3122ca857b042ac0df9d304cda6a7..be7ecb2018dddd2190a606c0954b794a1317c28e 100644 (file)
--- a/security/keys/process_keys.c
+++ b/security/keys/process_keys.c
@@ -657,7 +657,8 @@ try_again:
                        goto error;
 
                down_read(&cred->request_key_auth->sem);
-               if (cred->request_key_auth->flags & KEY_FLAG_REVOKED) {
+               if (test_bit(KEY_FLAG_REVOKED,
+                            &cred->request_key_auth->flags)) {
                        key_ref = ERR_PTR(-EKEYREVOKED);
                        key = NULL;
                } else {