x86, cacheinfo: Remove NUMA dependency, fix for AMD Fam10h rev D1
authorBorislav Petkov <borislav.petkov@amd.com>
Thu, 4 Feb 2010 11:09:07 +0000 (12:09 +0100)
committerH. Peter Anvin <hpa@zytor.com>
Fri, 19 Feb 2010 05:58:57 +0000 (21:58 -0800)
The show/store_cache_disable routines depend unnecessarily on NUMA's
cpu_to_node and the disabling of cache indices broke when !CONFIG_NUMA.
Remove that dependency by using a helper which is always correct.

While at it, enable L3 Cache Index disable on rev D1 Istanbuls which
sport the feature too.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
LKML-Reference: <20100218184339.GG20473@aftab>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
arch/x86/kernel/cpu/intel_cacheinfo.c

index 589b705e80edd125784e38a763c24adc2d6d116c..be5f5c28ddfbfb52aaab081f426055ead7b5cba6 100644 (file)
@@ -327,7 +327,7 @@ amd_check_l3_disable(int index, struct _cpuid4_info_regs *this_leaf)
 
        /* see errata #382 and #388 */
        if ((boot_cpu_data.x86 == 0x10) &&
-           ((boot_cpu_data.x86_model < 0x9) ||
+           ((boot_cpu_data.x86_model < 0x8) ||
             (boot_cpu_data.x86_mask  < 0x1)))
                return;
 
@@ -744,7 +744,7 @@ static ssize_t show_cache_disable(struct _cpuid4_info *this_leaf, char *buf,
                                  unsigned int index)
 {
        int cpu = cpumask_first(to_cpumask(this_leaf->shared_cpu_map));
-       int node = cpu_to_node(cpu);
+       int node = amd_get_nb_id(cpu);
        struct pci_dev *dev = node_to_k8_nb_misc(node);
        unsigned int reg = 0;
 
@@ -771,7 +771,7 @@ static ssize_t store_cache_disable(struct _cpuid4_info *this_leaf,
        const char *buf, size_t count, unsigned int index)
 {
        int cpu = cpumask_first(to_cpumask(this_leaf->shared_cpu_map));
-       int node = cpu_to_node(cpu);
+       int node = amd_get_nb_id(cpu);
        struct pci_dev *dev = node_to_k8_nb_misc(node);
        unsigned long val = 0;