media: lgdt3306a: Fix module count mismatch on usb unplug
authorBrad Love <brad@nextdimension.cc>
Fri, 5 Jan 2018 14:57:12 +0000 (09:57 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 May 2018 14:17:42 +0000 (16:17 +0200)
[ Upstream commit 835d66173a38538c072a7c393d02360dcfac8582 ]

When used as an i2c device there is a module usage count mismatch on
removal, preventing the driver from being used thereafter. dvb_attach
increments the usage count so it is properly balanced on removal.

On disconnect of Hauppauge SoloHD/DualHD before:

lsmod | grep lgdt3306a
lgdt3306a              28672  -1
i2c_mux                16384  1 lgdt3306a

On disconnect of Hauppauge SoloHD/DualHD after:

lsmod | grep lgdt3306a
lgdt3306a              28672  0
i2c_mux                16384  1 lgdt3306a

Signed-off-by: Brad Love <brad@nextdimension.cc>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/dvb-frontends/lgdt3306a.c

index c9b1eb38444e8cc199aeffa2c96244b141663b7d..b964ea6020c97648492f9458bb0b868ca3603e18 100644 (file)
@@ -2168,7 +2168,7 @@ static int lgdt3306a_probe(struct i2c_client *client,
                        sizeof(struct lgdt3306a_config));
 
        config->i2c_addr = client->addr;
-       fe = lgdt3306a_attach(config, client->adapter);
+       fe = dvb_attach(lgdt3306a_attach, config, client->adapter);
        if (fe == NULL) {
                ret = -ENODEV;
                goto err_fe;