drm/msm: Stop using drm_framebuffer_unregister_private
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 27 Dec 2016 10:49:21 +0000 (11:49 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 12 Jan 2017 09:52:56 +0000 (10:52 +0100)
This is the deprecated function for when you embedded the framebuffer
somewhere else (which breaks refcounting). But msm is using
drm_framebuffer_remove and a free-standing fb, so this is rendundant.

Cc: Rob Clark <robdclark@gmail.com>
Reviewed-by: Archit Taneja <architt@codeaurora.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1482835765-12044-1-git-send-email-daniel.vetter@ffwll.ch
drivers/gpu/drm/msm/msm_fbdev.c

index 5d68ab362d752fdc4669e7e74b01f5329c5dd449..f8a587eac6b86b495c540fcc973f05361ff585f1 100644 (file)
@@ -174,10 +174,8 @@ fail_unlock:
 fail:
 
        if (ret) {
-               if (fb) {
-                       drm_framebuffer_unregister_private(fb);
+               if (fb)
                        drm_framebuffer_remove(fb);
-               }
        }
 
        return ret;
@@ -247,7 +245,6 @@ void msm_fbdev_free(struct drm_device *dev)
        /* this will free the backing object */
        if (fbdev->fb) {
                msm_gem_put_vaddr(fbdev->bo);
-               drm_framebuffer_unregister_private(fbdev->fb);
                drm_framebuffer_remove(fbdev->fb);
        }