ALSA: pcm: use %s instead of %c for format of PCM buffer tracepoints
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Mon, 12 Jun 2017 00:41:46 +0000 (09:41 +0900)
committerTakashi Iwai <tiwai@suse.de>
Mon, 12 Jun 2017 06:49:24 +0000 (08:49 +0200)
As long as I know, in userspace, '%c' format on printing format for
tracepoint is replaced with '>c<' by existent tracing program; i.g.
'perf-trace' and 'trace-cmd'. This is inconvenient.

This commit replaces the format with '%s'. The length of letters in the
format string is not changed, thus this commit doesn't increase object
size.

In theory, I should work for improvements of these tracing programs, but
here I'd like to save my time to work for the other projects.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_trace.h

index e672368ab8787a6e324cabf1081e2c9d04253fef..3ddec1b8ae462343d30633929193d352bf56eae3 100644 (file)
@@ -34,9 +34,9 @@ TRACE_EVENT(hwptr,
                __entry->old_hw_ptr = (substream)->runtime->status->hw_ptr;
                __entry->hw_ptr_base = (substream)->runtime->hw_ptr_base;
        ),
-       TP_printk("pcmC%dD%d%c/sub%d: %s: pos=%lu, old=%lu, base=%lu, period=%lu, buf=%lu",
+       TP_printk("pcmC%dD%d%s/sub%d: %s: pos=%lu, old=%lu, base=%lu, period=%lu, buf=%lu",
                  __entry->card, __entry->device,
-                 __entry->stream == SNDRV_PCM_STREAM_PLAYBACK ? 'p' : 'c',
+                 __entry->stream == SNDRV_PCM_STREAM_PLAYBACK ? "p" : "c",
                  __entry->number,
                  __entry->in_interrupt ? "IRQ" : "POS",
                  (unsigned long)__entry->pos,
@@ -69,9 +69,9 @@ TRACE_EVENT(xrun,
                __entry->old_hw_ptr = (substream)->runtime->status->hw_ptr;
                __entry->hw_ptr_base = (substream)->runtime->hw_ptr_base;
        ),
-       TP_printk("pcmC%dD%d%c/sub%d: XRUN: old=%lu, base=%lu, period=%lu, buf=%lu",
+       TP_printk("pcmC%dD%d%s/sub%d: XRUN: old=%lu, base=%lu, period=%lu, buf=%lu",
                  __entry->card, __entry->device,
-                 __entry->stream == SNDRV_PCM_STREAM_PLAYBACK ? 'p' : 'c',
+                 __entry->stream == SNDRV_PCM_STREAM_PLAYBACK ? "p" : "c",
                  __entry->number,
                  (unsigned long)__entry->old_hw_ptr,
                  (unsigned long)__entry->hw_ptr_base,
@@ -96,9 +96,9 @@ TRACE_EVENT(hw_ptr_error,
                __entry->stream = (substream)->stream;
                __entry->reason = (why);
        ),
-       TP_printk("pcmC%dD%d%c/sub%d: ERROR: %s",
+       TP_printk("pcmC%dD%d%s/sub%d: ERROR: %s",
                  __entry->card, __entry->device,
-                 __entry->stream == SNDRV_PCM_STREAM_PLAYBACK ? 'p' : 'c',
+                 __entry->stream == SNDRV_PCM_STREAM_PLAYBACK ? "p" : "c",
                  __entry->number, __entry->reason)
 );