bpf: use skb_at_tc_ingress helper in tcf_bpf
authorDaniel Borkmann <daniel@iogearbox.net>
Mon, 12 Sep 2016 21:38:43 +0000 (23:38 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 15 Sep 2016 23:29:47 +0000 (19:29 -0400)
We have a small skb_at_tc_ingress() helper for testing for ingress, so
make use of it. cls_bpf already uses it and so should act_bpf.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/act_bpf.c

index 78400defa790736513a73db3e4cebbb20699b938..1d3960033f61d0f72d5039ba31ff1c8dc91d7cba 100644 (file)
@@ -39,10 +39,10 @@ static struct tc_action_ops act_bpf_ops;
 static int tcf_bpf(struct sk_buff *skb, const struct tc_action *act,
                   struct tcf_result *res)
 {
+       bool at_ingress = skb_at_tc_ingress(skb);
        struct tcf_bpf *prog = to_bpf(act);
        struct bpf_prog *filter;
        int action, filter_res;
-       bool at_ingress = G_TC_AT(skb->tc_verd) & AT_INGRESS;
 
        tcf_lastuse_update(&prog->tcf_tm);
        bstats_cpu_update(this_cpu_ptr(prog->common.cpu_bstats), skb);