sunvdc: Fix off-by-one in generic_request().
authorDavid S. Miller <davem@davemloft.net>
Thu, 14 Feb 2013 19:49:01 +0000 (11:49 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 14 Feb 2013 19:49:01 +0000 (11:49 -0800)
The 'operations' bitmap corresponds one-for-one with the operation
codes, no adjustment is necessary.

Reported-by: Mark Kettenis <mark.kettenis@xs4all.nl>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/block/sunvdc.c

index 564156a8e57251f68181a706f959f5b5299bfdf5..5814deb6963d52a875708e78a4a3a38eb148145e 100644 (file)
@@ -461,7 +461,7 @@ static int generic_request(struct vdc_port *port, u8 op, void *buf, int len)
        int op_len, err;
        void *req_buf;
 
-       if (!(((u64)1 << ((u64)op - 1)) & port->operations))
+       if (!(((u64)1 << (u64)op) & port->operations))
                return -EOPNOTSUPP;
 
        switch (op) {