drm/i915: move the suspend/resume register file out of dev_priv
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 2 Nov 2012 18:55:02 +0000 (19:55 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Sun, 11 Nov 2012 22:51:38 +0000 (23:51 +0100)
dev_priv has grown way too big, and grouping memebers into substructs
and moving them out of line helps re-gain some overview.

Unfortunatley I couldn't just call the substruct save and drop the prefix, since
that will make most member names clash with registers #defines. Changes in
i915_drv.h done by hand, everything else changed with
s/\<save\([A-Z]*\)/regfile.save\1/ in vim.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_drv.h
drivers/gpu/drm/i915/i915_suspend.c
drivers/gpu/drm/i915/intel_panel.c

index 4bce44ccd03eb9b4fcc8e1aa371d79431190cdf8..6a37efe7681d047f0e7d8b468ce4b77f6c32109c 100644 (file)
@@ -397,141 +397,7 @@ struct intel_gmbus {
        struct drm_i915_private *dev_priv;
 };
 
-typedef struct drm_i915_private {
-       struct drm_device *dev;
-
-       const struct intel_device_info *info;
-
-       int relative_constants_mode;
-
-       void __iomem *regs;
-
-       struct drm_i915_gt_funcs gt;
-       /** gt_fifo_count and the subsequent register write are synchronized
-        * with dev->struct_mutex. */
-       unsigned gt_fifo_count;
-       /** forcewake_count is protected by gt_lock */
-       unsigned forcewake_count;
-       /** gt_lock is also taken in irq contexts. */
-       struct spinlock gt_lock;
-
-       struct intel_gmbus gmbus[GMBUS_NUM_PORTS];
-
-       /** gmbus_mutex protects against concurrent usage of the single hw gmbus
-        * controller on different i2c buses. */
-       struct mutex gmbus_mutex;
-
-       /**
-        * Base address of the gmbus and gpio block.
-        */
-       uint32_t gpio_mmio_base;
-
-       struct pci_dev *bridge_dev;
-       struct intel_ring_buffer ring[I915_NUM_RINGS];
-       uint32_t next_seqno;
-
-       drm_dma_handle_t *status_page_dmah;
-       uint32_t counter;
-       struct drm_i915_gem_object *pwrctx;
-       struct drm_i915_gem_object *renderctx;
-
-       struct resource mch_res;
-
-       atomic_t irq_received;
-
-       /* protects the irq masks */
-       spinlock_t irq_lock;
-
-       /* DPIO indirect register protection */
-       spinlock_t dpio_lock;
-
-       /** Cached value of IMR to avoid reads in updating the bitfield */
-       u32 pipestat[2];
-       u32 irq_mask;
-       u32 gt_irq_mask;
-       u32 pch_irq_mask;
-
-       u32 hotplug_supported_mask;
-       struct work_struct hotplug_work;
-
-       int num_pipe;
-       int num_pch_pll;
-
-       /* For hangcheck timer */
-#define DRM_I915_HANGCHECK_PERIOD 1500 /* in ms */
-#define DRM_I915_HANGCHECK_JIFFIES msecs_to_jiffies(DRM_I915_HANGCHECK_PERIOD)
-       struct timer_list hangcheck_timer;
-       int hangcheck_count;
-       uint32_t last_acthd[I915_NUM_RINGS];
-       uint32_t prev_instdone[I915_NUM_INSTDONE_REG];
-
-       unsigned int stop_rings;
-
-       unsigned long cfb_size;
-       unsigned int cfb_fb;
-       enum plane cfb_plane;
-       int cfb_y;
-       struct intel_fbc_work *fbc_work;
-
-       struct intel_opregion opregion;
-
-       /* overlay */
-       struct intel_overlay *overlay;
-       bool sprite_scaling_enabled;
-
-       /* LVDS info */
-       int backlight_level;  /* restore backlight to this value */
-       bool backlight_enabled;
-       struct drm_display_mode *lfp_lvds_vbt_mode; /* if any */
-       struct drm_display_mode *sdvo_lvds_vbt_mode; /* if any */
-
-       /* Feature bits from the VBIOS */
-       unsigned int int_tv_support:1;
-       unsigned int lvds_dither:1;
-       unsigned int lvds_vbt:1;
-       unsigned int int_crt_support:1;
-       unsigned int lvds_use_ssc:1;
-       unsigned int display_clock_mode:1;
-       int lvds_ssc_freq;
-       unsigned int bios_lvds_val; /* initial [PCH_]LVDS reg val in VBIOS */
-       unsigned int lvds_val; /* used for checking LVDS channel mode */
-       struct {
-               int rate;
-               int lanes;
-               int preemphasis;
-               int vswing;
-
-               bool initialized;
-               bool support;
-               int bpp;
-               struct edp_power_seq pps;
-       } edp;
-       bool no_aux_handshake;
-
-       int crt_ddc_pin;
-       struct drm_i915_fence_reg fence_regs[I915_MAX_NUM_FENCES]; /* assume 965 */
-       int fence_reg_start; /* 4 if userland hasn't ioctl'd us yet */
-       int num_fence_regs; /* 8 on pre-965, 16 otherwise */
-
-       unsigned int fsb_freq, mem_freq, is_ddr3;
-
-       spinlock_t error_lock;
-       /* Protected by dev->error_lock. */
-       struct drm_i915_error_state *first_error;
-       struct work_struct error_work;
-       struct completion error_completion;
-       struct workqueue_struct *wq;
-
-       /* Display functions */
-       struct drm_i915_display_funcs display;
-
-       /* PCH chipset type */
-       enum intel_pch pch_type;
-
-       unsigned long quirks;
-
-       /* Register state */
-       bool modeset_on_lid;
+struct i915_suspend_saved_registers {
        u8 saveLBB;
        u32 saveDSPACNTR;
        u32 saveDSPBCNTR;
@@ -682,6 +548,142 @@ typedef struct drm_i915_private {
        u32 savePIPEB_LINK_N1;
        u32 saveMCHBAR_RENDER_STANDBY;
        u32 savePCH_PORT_HOTPLUG;
+};
+typedef struct drm_i915_private {
+       struct drm_device *dev;
+
+       const struct intel_device_info *info;
+
+       int relative_constants_mode;
+
+       void __iomem *regs;
+
+       struct drm_i915_gt_funcs gt;
+       /** gt_fifo_count and the subsequent register write are synchronized
+        * with dev->struct_mutex. */
+       unsigned gt_fifo_count;
+       /** forcewake_count is protected by gt_lock */
+       unsigned forcewake_count;
+       /** gt_lock is also taken in irq contexts. */
+       struct spinlock gt_lock;
+
+       struct intel_gmbus gmbus[GMBUS_NUM_PORTS];
+
+       /** gmbus_mutex protects against concurrent usage of the single hw gmbus
+        * controller on different i2c buses. */
+       struct mutex gmbus_mutex;
+
+       /**
+        * Base address of the gmbus and gpio block.
+        */
+       uint32_t gpio_mmio_base;
+
+       struct pci_dev *bridge_dev;
+       struct intel_ring_buffer ring[I915_NUM_RINGS];
+       uint32_t next_seqno;
+
+       drm_dma_handle_t *status_page_dmah;
+       uint32_t counter;
+       struct drm_i915_gem_object *pwrctx;
+       struct drm_i915_gem_object *renderctx;
+
+       struct resource mch_res;
+
+       atomic_t irq_received;
+
+       /* protects the irq masks */
+       spinlock_t irq_lock;
+
+       /* DPIO indirect register protection */
+       spinlock_t dpio_lock;
+
+       /** Cached value of IMR to avoid reads in updating the bitfield */
+       u32 pipestat[2];
+       u32 irq_mask;
+       u32 gt_irq_mask;
+       u32 pch_irq_mask;
+
+       u32 hotplug_supported_mask;
+       struct work_struct hotplug_work;
+
+       int num_pipe;
+       int num_pch_pll;
+
+       /* For hangcheck timer */
+#define DRM_I915_HANGCHECK_PERIOD 1500 /* in ms */
+#define DRM_I915_HANGCHECK_JIFFIES msecs_to_jiffies(DRM_I915_HANGCHECK_PERIOD)
+       struct timer_list hangcheck_timer;
+       int hangcheck_count;
+       uint32_t last_acthd[I915_NUM_RINGS];
+       uint32_t prev_instdone[I915_NUM_INSTDONE_REG];
+
+       unsigned int stop_rings;
+
+       unsigned long cfb_size;
+       unsigned int cfb_fb;
+       enum plane cfb_plane;
+       int cfb_y;
+       struct intel_fbc_work *fbc_work;
+
+       struct intel_opregion opregion;
+
+       /* overlay */
+       struct intel_overlay *overlay;
+       bool sprite_scaling_enabled;
+
+       /* LVDS info */
+       int backlight_level;  /* restore backlight to this value */
+       bool backlight_enabled;
+       struct drm_display_mode *lfp_lvds_vbt_mode; /* if any */
+       struct drm_display_mode *sdvo_lvds_vbt_mode; /* if any */
+
+       /* Feature bits from the VBIOS */
+       unsigned int int_tv_support:1;
+       unsigned int lvds_dither:1;
+       unsigned int lvds_vbt:1;
+       unsigned int int_crt_support:1;
+       unsigned int lvds_use_ssc:1;
+       unsigned int display_clock_mode:1;
+       int lvds_ssc_freq;
+       unsigned int bios_lvds_val; /* initial [PCH_]LVDS reg val in VBIOS */
+       unsigned int lvds_val; /* used for checking LVDS channel mode */
+       struct {
+               int rate;
+               int lanes;
+               int preemphasis;
+               int vswing;
+
+               bool initialized;
+               bool support;
+               int bpp;
+               struct edp_power_seq pps;
+       } edp;
+       bool no_aux_handshake;
+
+       int crt_ddc_pin;
+       struct drm_i915_fence_reg fence_regs[I915_MAX_NUM_FENCES]; /* assume 965 */
+       int fence_reg_start; /* 4 if userland hasn't ioctl'd us yet */
+       int num_fence_regs; /* 8 on pre-965, 16 otherwise */
+
+       unsigned int fsb_freq, mem_freq, is_ddr3;
+
+       spinlock_t error_lock;
+       /* Protected by dev->error_lock. */
+       struct drm_i915_error_state *first_error;
+       struct work_struct error_work;
+       struct completion error_completion;
+       struct workqueue_struct *wq;
+
+       /* Display functions */
+       struct drm_i915_display_funcs display;
+
+       /* PCH chipset type */
+       enum intel_pch pch_type;
+
+       unsigned long quirks;
+
+       /* Register state */
+       bool modeset_on_lid;
 
        struct {
                /** Bridge to intel-gtt-ko */
@@ -884,6 +886,8 @@ typedef struct drm_i915_private {
        struct work_struct parity_error_work;
        bool hw_contexts_disabled;
        uint32_t hw_context_size;
+
+       struct i915_suspend_saved_registers regfile;
 } drm_i915_private_t;
 
 /* Iterate over initialised rings */
index fd82415d2cfa54d6e0a3888084db6e1b47b5db88..a818eba7cb66852a747fd5e7d45f1bebb8f3d0fc 100644 (file)
@@ -60,9 +60,9 @@ static void i915_save_palette(struct drm_device *dev, enum pipe pipe)
                reg = (pipe == PIPE_A) ? _LGC_PALETTE_A : _LGC_PALETTE_B;
 
        if (pipe == PIPE_A)
-               array = dev_priv->save_palette_a;
+               array = dev_priv->regfile.save_palette_a;
        else
-               array = dev_priv->save_palette_b;
+               array = dev_priv->regfile.save_palette_b;
 
        for (i = 0; i < 256; i++)
                array[i] = I915_READ(reg + (i << 2));
@@ -82,9 +82,9 @@ static void i915_restore_palette(struct drm_device *dev, enum pipe pipe)
                reg = (pipe == PIPE_A) ? _LGC_PALETTE_A : _LGC_PALETTE_B;
 
        if (pipe == PIPE_A)
-               array = dev_priv->save_palette_a;
+               array = dev_priv->regfile.save_palette_a;
        else
-               array = dev_priv->save_palette_b;
+               array = dev_priv->regfile.save_palette_b;
 
        for (i = 0; i < 256; i++)
                I915_WRITE(reg + (i << 2), array[i]);
@@ -131,11 +131,11 @@ static void i915_save_vga(struct drm_device *dev)
        u16 cr_index, cr_data, st01;
 
        /* VGA color palette registers */
-       dev_priv->saveDACMASK = I915_READ8(VGA_DACMASK);
+       dev_priv->regfile.saveDACMASK = I915_READ8(VGA_DACMASK);
 
        /* MSR bits */
-       dev_priv->saveMSR = I915_READ8(VGA_MSR_READ);
-       if (dev_priv->saveMSR & VGA_MSR_CGA_MODE) {
+       dev_priv->regfile.saveMSR = I915_READ8(VGA_MSR_READ);
+       if (dev_priv->regfile.saveMSR & VGA_MSR_CGA_MODE) {
                cr_index = VGA_CR_INDEX_CGA;
                cr_data = VGA_CR_DATA_CGA;
                st01 = VGA_ST01_CGA;
@@ -150,35 +150,35 @@ static void i915_save_vga(struct drm_device *dev)
                           i915_read_indexed(dev, cr_index, cr_data, 0x11) &
                           (~0x80));
        for (i = 0; i <= 0x24; i++)
-               dev_priv->saveCR[i] =
+               dev_priv->regfile.saveCR[i] =
                        i915_read_indexed(dev, cr_index, cr_data, i);
        /* Make sure we don't turn off CR group 0 writes */
-       dev_priv->saveCR[0x11] &= ~0x80;
+       dev_priv->regfile.saveCR[0x11] &= ~0x80;
 
        /* Attribute controller registers */
        I915_READ8(st01);
-       dev_priv->saveAR_INDEX = I915_READ8(VGA_AR_INDEX);
+       dev_priv->regfile.saveAR_INDEX = I915_READ8(VGA_AR_INDEX);
        for (i = 0; i <= 0x14; i++)
-               dev_priv->saveAR[i] = i915_read_ar(dev, st01, i, 0);
+               dev_priv->regfile.saveAR[i] = i915_read_ar(dev, st01, i, 0);
        I915_READ8(st01);
-       I915_WRITE8(VGA_AR_INDEX, dev_priv->saveAR_INDEX);
+       I915_WRITE8(VGA_AR_INDEX, dev_priv->regfile.saveAR_INDEX);
        I915_READ8(st01);
 
        /* Graphics controller registers */
        for (i = 0; i < 9; i++)
-               dev_priv->saveGR[i] =
+               dev_priv->regfile.saveGR[i] =
                        i915_read_indexed(dev, VGA_GR_INDEX, VGA_GR_DATA, i);
 
-       dev_priv->saveGR[0x10] =
+       dev_priv->regfile.saveGR[0x10] =
                i915_read_indexed(dev, VGA_GR_INDEX, VGA_GR_DATA, 0x10);
-       dev_priv->saveGR[0x11] =
+       dev_priv->regfile.saveGR[0x11] =
                i915_read_indexed(dev, VGA_GR_INDEX, VGA_GR_DATA, 0x11);
-       dev_priv->saveGR[0x18] =
+       dev_priv->regfile.saveGR[0x18] =
                i915_read_indexed(dev, VGA_GR_INDEX, VGA_GR_DATA, 0x18);
 
        /* Sequencer registers */
        for (i = 0; i < 8; i++)
-               dev_priv->saveSR[i] =
+               dev_priv->regfile.saveSR[i] =
                        i915_read_indexed(dev, VGA_SR_INDEX, VGA_SR_DATA, i);
 }
 
@@ -189,8 +189,8 @@ static void i915_restore_vga(struct drm_device *dev)
        u16 cr_index, cr_data, st01;
 
        /* MSR bits */
-       I915_WRITE8(VGA_MSR_WRITE, dev_priv->saveMSR);
-       if (dev_priv->saveMSR & VGA_MSR_CGA_MODE) {
+       I915_WRITE8(VGA_MSR_WRITE, dev_priv->regfile.saveMSR);
+       if (dev_priv->regfile.saveMSR & VGA_MSR_CGA_MODE) {
                cr_index = VGA_CR_INDEX_CGA;
                cr_data = VGA_CR_DATA_CGA;
                st01 = VGA_ST01_CGA;
@@ -203,36 +203,36 @@ static void i915_restore_vga(struct drm_device *dev)
        /* Sequencer registers, don't write SR07 */
        for (i = 0; i < 7; i++)
                i915_write_indexed(dev, VGA_SR_INDEX, VGA_SR_DATA, i,
-                                  dev_priv->saveSR[i]);
+                                  dev_priv->regfile.saveSR[i]);
 
        /* CRT controller regs */
        /* Enable CR group 0 writes */
-       i915_write_indexed(dev, cr_index, cr_data, 0x11, dev_priv->saveCR[0x11]);
+       i915_write_indexed(dev, cr_index, cr_data, 0x11, dev_priv->regfile.saveCR[0x11]);
        for (i = 0; i <= 0x24; i++)
-               i915_write_indexed(dev, cr_index, cr_data, i, dev_priv->saveCR[i]);
+               i915_write_indexed(dev, cr_index, cr_data, i, dev_priv->regfile.saveCR[i]);
 
        /* Graphics controller regs */
        for (i = 0; i < 9; i++)
                i915_write_indexed(dev, VGA_GR_INDEX, VGA_GR_DATA, i,
-                                  dev_priv->saveGR[i]);
+                                  dev_priv->regfile.saveGR[i]);
 
        i915_write_indexed(dev, VGA_GR_INDEX, VGA_GR_DATA, 0x10,
-                          dev_priv->saveGR[0x10]);
+                          dev_priv->regfile.saveGR[0x10]);
        i915_write_indexed(dev, VGA_GR_INDEX, VGA_GR_DATA, 0x11,
-                          dev_priv->saveGR[0x11]);
+                          dev_priv->regfile.saveGR[0x11]);
        i915_write_indexed(dev, VGA_GR_INDEX, VGA_GR_DATA, 0x18,
-                          dev_priv->saveGR[0x18]);
+                          dev_priv->regfile.saveGR[0x18]);
 
        /* Attribute controller registers */
        I915_READ8(st01); /* switch back to index mode */
        for (i = 0; i <= 0x14; i++)
-               i915_write_ar(dev, st01, i, dev_priv->saveAR[i], 0);
+               i915_write_ar(dev, st01, i, dev_priv->regfile.saveAR[i], 0);
        I915_READ8(st01); /* switch back to index mode */
-       I915_WRITE8(VGA_AR_INDEX, dev_priv->saveAR_INDEX | 0x20);
+       I915_WRITE8(VGA_AR_INDEX, dev_priv->regfile.saveAR_INDEX | 0x20);
        I915_READ8(st01);
 
        /* VGA color palette registers */
-       I915_WRITE8(VGA_DACMASK, dev_priv->saveDACMASK);
+       I915_WRITE8(VGA_DACMASK, dev_priv->regfile.saveDACMASK);
 }
 
 static void i915_save_modeset_reg(struct drm_device *dev)
@@ -244,161 +244,161 @@ static void i915_save_modeset_reg(struct drm_device *dev)
                return;
 
        /* Cursor state */
-       dev_priv->saveCURACNTR = I915_READ(_CURACNTR);
-       dev_priv->saveCURAPOS = I915_READ(_CURAPOS);
-       dev_priv->saveCURABASE = I915_READ(_CURABASE);
-       dev_priv->saveCURBCNTR = I915_READ(_CURBCNTR);
-       dev_priv->saveCURBPOS = I915_READ(_CURBPOS);
-       dev_priv->saveCURBBASE = I915_READ(_CURBBASE);
+       dev_priv->regfile.saveCURACNTR = I915_READ(_CURACNTR);
+       dev_priv->regfile.saveCURAPOS = I915_READ(_CURAPOS);
+       dev_priv->regfile.saveCURABASE = I915_READ(_CURABASE);
+       dev_priv->regfile.saveCURBCNTR = I915_READ(_CURBCNTR);
+       dev_priv->regfile.saveCURBPOS = I915_READ(_CURBPOS);
+       dev_priv->regfile.saveCURBBASE = I915_READ(_CURBBASE);
        if (IS_GEN2(dev))
-               dev_priv->saveCURSIZE = I915_READ(CURSIZE);
+               dev_priv->regfile.saveCURSIZE = I915_READ(CURSIZE);
 
        if (HAS_PCH_SPLIT(dev)) {
-               dev_priv->savePCH_DREF_CONTROL = I915_READ(PCH_DREF_CONTROL);
-               dev_priv->saveDISP_ARB_CTL = I915_READ(DISP_ARB_CTL);
+               dev_priv->regfile.savePCH_DREF_CONTROL = I915_READ(PCH_DREF_CONTROL);
+               dev_priv->regfile.saveDISP_ARB_CTL = I915_READ(DISP_ARB_CTL);
        }
 
        /* Pipe & plane A info */
-       dev_priv->savePIPEACONF = I915_READ(_PIPEACONF);
-       dev_priv->savePIPEASRC = I915_READ(_PIPEASRC);
+       dev_priv->regfile.savePIPEACONF = I915_READ(_PIPEACONF);
+       dev_priv->regfile.savePIPEASRC = I915_READ(_PIPEASRC);
        if (HAS_PCH_SPLIT(dev)) {
-               dev_priv->saveFPA0 = I915_READ(_PCH_FPA0);
-               dev_priv->saveFPA1 = I915_READ(_PCH_FPA1);
-               dev_priv->saveDPLL_A = I915_READ(_PCH_DPLL_A);
+               dev_priv->regfile.saveFPA0 = I915_READ(_PCH_FPA0);
+               dev_priv->regfile.saveFPA1 = I915_READ(_PCH_FPA1);
+               dev_priv->regfile.saveDPLL_A = I915_READ(_PCH_DPLL_A);
        } else {
-               dev_priv->saveFPA0 = I915_READ(_FPA0);
-               dev_priv->saveFPA1 = I915_READ(_FPA1);
-               dev_priv->saveDPLL_A = I915_READ(_DPLL_A);
+               dev_priv->regfile.saveFPA0 = I915_READ(_FPA0);
+               dev_priv->regfile.saveFPA1 = I915_READ(_FPA1);
+               dev_priv->regfile.saveDPLL_A = I915_READ(_DPLL_A);
        }
        if (INTEL_INFO(dev)->gen >= 4 && !HAS_PCH_SPLIT(dev))
-               dev_priv->saveDPLL_A_MD = I915_READ(_DPLL_A_MD);
-       dev_priv->saveHTOTAL_A = I915_READ(_HTOTAL_A);
-       dev_priv->saveHBLANK_A = I915_READ(_HBLANK_A);
-       dev_priv->saveHSYNC_A = I915_READ(_HSYNC_A);
-       dev_priv->saveVTOTAL_A = I915_READ(_VTOTAL_A);
-       dev_priv->saveVBLANK_A = I915_READ(_VBLANK_A);
-       dev_priv->saveVSYNC_A = I915_READ(_VSYNC_A);
+               dev_priv->regfile.saveDPLL_A_MD = I915_READ(_DPLL_A_MD);
+       dev_priv->regfile.saveHTOTAL_A = I915_READ(_HTOTAL_A);
+       dev_priv->regfile.saveHBLANK_A = I915_READ(_HBLANK_A);
+       dev_priv->regfile.saveHSYNC_A = I915_READ(_HSYNC_A);
+       dev_priv->regfile.saveVTOTAL_A = I915_READ(_VTOTAL_A);
+       dev_priv->regfile.saveVBLANK_A = I915_READ(_VBLANK_A);
+       dev_priv->regfile.saveVSYNC_A = I915_READ(_VSYNC_A);
        if (!HAS_PCH_SPLIT(dev))
-               dev_priv->saveBCLRPAT_A = I915_READ(_BCLRPAT_A);
+               dev_priv->regfile.saveBCLRPAT_A = I915_READ(_BCLRPAT_A);
 
        if (HAS_PCH_SPLIT(dev)) {
-               dev_priv->savePIPEA_DATA_M1 = I915_READ(_PIPEA_DATA_M1);
-               dev_priv->savePIPEA_DATA_N1 = I915_READ(_PIPEA_DATA_N1);
-               dev_priv->savePIPEA_LINK_M1 = I915_READ(_PIPEA_LINK_M1);
-               dev_priv->savePIPEA_LINK_N1 = I915_READ(_PIPEA_LINK_N1);
-
-               dev_priv->saveFDI_TXA_CTL = I915_READ(_FDI_TXA_CTL);
-               dev_priv->saveFDI_RXA_CTL = I915_READ(_FDI_RXA_CTL);
-
-               dev_priv->savePFA_CTL_1 = I915_READ(_PFA_CTL_1);
-               dev_priv->savePFA_WIN_SZ = I915_READ(_PFA_WIN_SZ);
-               dev_priv->savePFA_WIN_POS = I915_READ(_PFA_WIN_POS);
-
-               dev_priv->saveTRANSACONF = I915_READ(_TRANSACONF);
-               dev_priv->saveTRANS_HTOTAL_A = I915_READ(_TRANS_HTOTAL_A);
-               dev_priv->saveTRANS_HBLANK_A = I915_READ(_TRANS_HBLANK_A);
-               dev_priv->saveTRANS_HSYNC_A = I915_READ(_TRANS_HSYNC_A);
-               dev_priv->saveTRANS_VTOTAL_A = I915_READ(_TRANS_VTOTAL_A);
-               dev_priv->saveTRANS_VBLANK_A = I915_READ(_TRANS_VBLANK_A);
-               dev_priv->saveTRANS_VSYNC_A = I915_READ(_TRANS_VSYNC_A);
-       }
-
-       dev_priv->saveDSPACNTR = I915_READ(_DSPACNTR);
-       dev_priv->saveDSPASTRIDE = I915_READ(_DSPASTRIDE);
-       dev_priv->saveDSPASIZE = I915_READ(_DSPASIZE);
-       dev_priv->saveDSPAPOS = I915_READ(_DSPAPOS);
-       dev_priv->saveDSPAADDR = I915_READ(_DSPAADDR);
+               dev_priv->regfile.savePIPEA_DATA_M1 = I915_READ(_PIPEA_DATA_M1);
+               dev_priv->regfile.savePIPEA_DATA_N1 = I915_READ(_PIPEA_DATA_N1);
+               dev_priv->regfile.savePIPEA_LINK_M1 = I915_READ(_PIPEA_LINK_M1);
+               dev_priv->regfile.savePIPEA_LINK_N1 = I915_READ(_PIPEA_LINK_N1);
+
+               dev_priv->regfile.saveFDI_TXA_CTL = I915_READ(_FDI_TXA_CTL);
+               dev_priv->regfile.saveFDI_RXA_CTL = I915_READ(_FDI_RXA_CTL);
+
+               dev_priv->regfile.savePFA_CTL_1 = I915_READ(_PFA_CTL_1);
+               dev_priv->regfile.savePFA_WIN_SZ = I915_READ(_PFA_WIN_SZ);
+               dev_priv->regfile.savePFA_WIN_POS = I915_READ(_PFA_WIN_POS);
+
+               dev_priv->regfile.saveTRANSACONF = I915_READ(_TRANSACONF);
+               dev_priv->regfile.saveTRANS_HTOTAL_A = I915_READ(_TRANS_HTOTAL_A);
+               dev_priv->regfile.saveTRANS_HBLANK_A = I915_READ(_TRANS_HBLANK_A);
+               dev_priv->regfile.saveTRANS_HSYNC_A = I915_READ(_TRANS_HSYNC_A);
+               dev_priv->regfile.saveTRANS_VTOTAL_A = I915_READ(_TRANS_VTOTAL_A);
+               dev_priv->regfile.saveTRANS_VBLANK_A = I915_READ(_TRANS_VBLANK_A);
+               dev_priv->regfile.saveTRANS_VSYNC_A = I915_READ(_TRANS_VSYNC_A);
+       }
+
+       dev_priv->regfile.saveDSPACNTR = I915_READ(_DSPACNTR);
+       dev_priv->regfile.saveDSPASTRIDE = I915_READ(_DSPASTRIDE);
+       dev_priv->regfile.saveDSPASIZE = I915_READ(_DSPASIZE);
+       dev_priv->regfile.saveDSPAPOS = I915_READ(_DSPAPOS);
+       dev_priv->regfile.saveDSPAADDR = I915_READ(_DSPAADDR);
        if (INTEL_INFO(dev)->gen >= 4) {
-               dev_priv->saveDSPASURF = I915_READ(_DSPASURF);
-               dev_priv->saveDSPATILEOFF = I915_READ(_DSPATILEOFF);
+               dev_priv->regfile.saveDSPASURF = I915_READ(_DSPASURF);
+               dev_priv->regfile.saveDSPATILEOFF = I915_READ(_DSPATILEOFF);
        }
        i915_save_palette(dev, PIPE_A);
-       dev_priv->savePIPEASTAT = I915_READ(_PIPEASTAT);
+       dev_priv->regfile.savePIPEASTAT = I915_READ(_PIPEASTAT);
 
        /* Pipe & plane B info */
-       dev_priv->savePIPEBCONF = I915_READ(_PIPEBCONF);
-       dev_priv->savePIPEBSRC = I915_READ(_PIPEBSRC);
+       dev_priv->regfile.savePIPEBCONF = I915_READ(_PIPEBCONF);
+       dev_priv->regfile.savePIPEBSRC = I915_READ(_PIPEBSRC);
        if (HAS_PCH_SPLIT(dev)) {
-               dev_priv->saveFPB0 = I915_READ(_PCH_FPB0);
-               dev_priv->saveFPB1 = I915_READ(_PCH_FPB1);
-               dev_priv->saveDPLL_B = I915_READ(_PCH_DPLL_B);
+               dev_priv->regfile.saveFPB0 = I915_READ(_PCH_FPB0);
+               dev_priv->regfile.saveFPB1 = I915_READ(_PCH_FPB1);
+               dev_priv->regfile.saveDPLL_B = I915_READ(_PCH_DPLL_B);
        } else {
-               dev_priv->saveFPB0 = I915_READ(_FPB0);
-               dev_priv->saveFPB1 = I915_READ(_FPB1);
-               dev_priv->saveDPLL_B = I915_READ(_DPLL_B);
+               dev_priv->regfile.saveFPB0 = I915_READ(_FPB0);
+               dev_priv->regfile.saveFPB1 = I915_READ(_FPB1);
+               dev_priv->regfile.saveDPLL_B = I915_READ(_DPLL_B);
        }
        if (INTEL_INFO(dev)->gen >= 4 && !HAS_PCH_SPLIT(dev))
-               dev_priv->saveDPLL_B_MD = I915_READ(_DPLL_B_MD);
-       dev_priv->saveHTOTAL_B = I915_READ(_HTOTAL_B);
-       dev_priv->saveHBLANK_B = I915_READ(_HBLANK_B);
-       dev_priv->saveHSYNC_B = I915_READ(_HSYNC_B);
-       dev_priv->saveVTOTAL_B = I915_READ(_VTOTAL_B);
-       dev_priv->saveVBLANK_B = I915_READ(_VBLANK_B);
-       dev_priv->saveVSYNC_B = I915_READ(_VSYNC_B);
+               dev_priv->regfile.saveDPLL_B_MD = I915_READ(_DPLL_B_MD);
+       dev_priv->regfile.saveHTOTAL_B = I915_READ(_HTOTAL_B);
+       dev_priv->regfile.saveHBLANK_B = I915_READ(_HBLANK_B);
+       dev_priv->regfile.saveHSYNC_B = I915_READ(_HSYNC_B);
+       dev_priv->regfile.saveVTOTAL_B = I915_READ(_VTOTAL_B);
+       dev_priv->regfile.saveVBLANK_B = I915_READ(_VBLANK_B);
+       dev_priv->regfile.saveVSYNC_B = I915_READ(_VSYNC_B);
        if (!HAS_PCH_SPLIT(dev))
-               dev_priv->saveBCLRPAT_B = I915_READ(_BCLRPAT_B);
+               dev_priv->regfile.saveBCLRPAT_B = I915_READ(_BCLRPAT_B);
 
        if (HAS_PCH_SPLIT(dev)) {
-               dev_priv->savePIPEB_DATA_M1 = I915_READ(_PIPEB_DATA_M1);
-               dev_priv->savePIPEB_DATA_N1 = I915_READ(_PIPEB_DATA_N1);
-               dev_priv->savePIPEB_LINK_M1 = I915_READ(_PIPEB_LINK_M1);
-               dev_priv->savePIPEB_LINK_N1 = I915_READ(_PIPEB_LINK_N1);
-
-               dev_priv->saveFDI_TXB_CTL = I915_READ(_FDI_TXB_CTL);
-               dev_priv->saveFDI_RXB_CTL = I915_READ(_FDI_RXB_CTL);
-
-               dev_priv->savePFB_CTL_1 = I915_READ(_PFB_CTL_1);
-               dev_priv->savePFB_WIN_SZ = I915_READ(_PFB_WIN_SZ);
-               dev_priv->savePFB_WIN_POS = I915_READ(_PFB_WIN_POS);
-
-               dev_priv->saveTRANSBCONF = I915_READ(_TRANSBCONF);
-               dev_priv->saveTRANS_HTOTAL_B = I915_READ(_TRANS_HTOTAL_B);
-               dev_priv->saveTRANS_HBLANK_B = I915_READ(_TRANS_HBLANK_B);
-               dev_priv->saveTRANS_HSYNC_B = I915_READ(_TRANS_HSYNC_B);
-               dev_priv->saveTRANS_VTOTAL_B = I915_READ(_TRANS_VTOTAL_B);
-               dev_priv->saveTRANS_VBLANK_B = I915_READ(_TRANS_VBLANK_B);
-               dev_priv->saveTRANS_VSYNC_B = I915_READ(_TRANS_VSYNC_B);
-       }
-
-       dev_priv->saveDSPBCNTR = I915_READ(_DSPBCNTR);
-       dev_priv->saveDSPBSTRIDE = I915_READ(_DSPBSTRIDE);
-       dev_priv->saveDSPBSIZE = I915_READ(_DSPBSIZE);
-       dev_priv->saveDSPBPOS = I915_READ(_DSPBPOS);
-       dev_priv->saveDSPBADDR = I915_READ(_DSPBADDR);
+               dev_priv->regfile.savePIPEB_DATA_M1 = I915_READ(_PIPEB_DATA_M1);
+               dev_priv->regfile.savePIPEB_DATA_N1 = I915_READ(_PIPEB_DATA_N1);
+               dev_priv->regfile.savePIPEB_LINK_M1 = I915_READ(_PIPEB_LINK_M1);
+               dev_priv->regfile.savePIPEB_LINK_N1 = I915_READ(_PIPEB_LINK_N1);
+
+               dev_priv->regfile.saveFDI_TXB_CTL = I915_READ(_FDI_TXB_CTL);
+               dev_priv->regfile.saveFDI_RXB_CTL = I915_READ(_FDI_RXB_CTL);
+
+               dev_priv->regfile.savePFB_CTL_1 = I915_READ(_PFB_CTL_1);
+               dev_priv->regfile.savePFB_WIN_SZ = I915_READ(_PFB_WIN_SZ);
+               dev_priv->regfile.savePFB_WIN_POS = I915_READ(_PFB_WIN_POS);
+
+               dev_priv->regfile.saveTRANSBCONF = I915_READ(_TRANSBCONF);
+               dev_priv->regfile.saveTRANS_HTOTAL_B = I915_READ(_TRANS_HTOTAL_B);
+               dev_priv->regfile.saveTRANS_HBLANK_B = I915_READ(_TRANS_HBLANK_B);
+               dev_priv->regfile.saveTRANS_HSYNC_B = I915_READ(_TRANS_HSYNC_B);
+               dev_priv->regfile.saveTRANS_VTOTAL_B = I915_READ(_TRANS_VTOTAL_B);
+               dev_priv->regfile.saveTRANS_VBLANK_B = I915_READ(_TRANS_VBLANK_B);
+               dev_priv->regfile.saveTRANS_VSYNC_B = I915_READ(_TRANS_VSYNC_B);
+       }
+
+       dev_priv->regfile.saveDSPBCNTR = I915_READ(_DSPBCNTR);
+       dev_priv->regfile.saveDSPBSTRIDE = I915_READ(_DSPBSTRIDE);
+       dev_priv->regfile.saveDSPBSIZE = I915_READ(_DSPBSIZE);
+       dev_priv->regfile.saveDSPBPOS = I915_READ(_DSPBPOS);
+       dev_priv->regfile.saveDSPBADDR = I915_READ(_DSPBADDR);
        if (INTEL_INFO(dev)->gen >= 4) {
-               dev_priv->saveDSPBSURF = I915_READ(_DSPBSURF);
-               dev_priv->saveDSPBTILEOFF = I915_READ(_DSPBTILEOFF);
+               dev_priv->regfile.saveDSPBSURF = I915_READ(_DSPBSURF);
+               dev_priv->regfile.saveDSPBTILEOFF = I915_READ(_DSPBTILEOFF);
        }
        i915_save_palette(dev, PIPE_B);
-       dev_priv->savePIPEBSTAT = I915_READ(_PIPEBSTAT);
+       dev_priv->regfile.savePIPEBSTAT = I915_READ(_PIPEBSTAT);
 
        /* Fences */
        switch (INTEL_INFO(dev)->gen) {
        case 7:
        case 6:
                for (i = 0; i < 16; i++)
-                       dev_priv->saveFENCE[i] = I915_READ64(FENCE_REG_SANDYBRIDGE_0 + (i * 8));
+                       dev_priv->regfile.saveFENCE[i] = I915_READ64(FENCE_REG_SANDYBRIDGE_0 + (i * 8));
                break;
        case 5:
        case 4:
                for (i = 0; i < 16; i++)
-                       dev_priv->saveFENCE[i] = I915_READ64(FENCE_REG_965_0 + (i * 8));
+                       dev_priv->regfile.saveFENCE[i] = I915_READ64(FENCE_REG_965_0 + (i * 8));
                break;
        case 3:
                if (IS_I945G(dev) || IS_I945GM(dev) || IS_G33(dev))
                        for (i = 0; i < 8; i++)
-                               dev_priv->saveFENCE[i+8] = I915_READ(FENCE_REG_945_8 + (i * 4));
+                               dev_priv->regfile.saveFENCE[i+8] = I915_READ(FENCE_REG_945_8 + (i * 4));
        case 2:
                for (i = 0; i < 8; i++)
-                       dev_priv->saveFENCE[i] = I915_READ(FENCE_REG_830_0 + (i * 4));
+                       dev_priv->regfile.saveFENCE[i] = I915_READ(FENCE_REG_830_0 + (i * 4));
                break;
        }
 
        /* CRT state */
        if (HAS_PCH_SPLIT(dev))
-               dev_priv->saveADPA = I915_READ(PCH_ADPA);
+               dev_priv->regfile.saveADPA = I915_READ(PCH_ADPA);
        else
-               dev_priv->saveADPA = I915_READ(ADPA);
+               dev_priv->regfile.saveADPA = I915_READ(ADPA);
 
        return;
 }
@@ -418,20 +418,20 @@ static void i915_restore_modeset_reg(struct drm_device *dev)
        case 7:
        case 6:
                for (i = 0; i < 16; i++)
-                       I915_WRITE64(FENCE_REG_SANDYBRIDGE_0 + (i * 8), dev_priv->saveFENCE[i]);
+                       I915_WRITE64(FENCE_REG_SANDYBRIDGE_0 + (i * 8), dev_priv->regfile.saveFENCE[i]);
                break;
        case 5:
        case 4:
                for (i = 0; i < 16; i++)
-                       I915_WRITE64(FENCE_REG_965_0 + (i * 8), dev_priv->saveFENCE[i]);
+                       I915_WRITE64(FENCE_REG_965_0 + (i * 8), dev_priv->regfile.saveFENCE[i]);
                break;
        case 3:
        case 2:
                if (IS_I945G(dev) || IS_I945GM(dev) || IS_G33(dev))
                        for (i = 0; i < 8; i++)
-                               I915_WRITE(FENCE_REG_945_8 + (i * 4), dev_priv->saveFENCE[i+8]);
+                               I915_WRITE(FENCE_REG_945_8 + (i * 4), dev_priv->regfile.saveFENCE[i+8]);
                for (i = 0; i < 8; i++)
-                       I915_WRITE(FENCE_REG_830_0 + (i * 4), dev_priv->saveFENCE[i]);
+                       I915_WRITE(FENCE_REG_830_0 + (i * 4), dev_priv->regfile.saveFENCE[i]);
                break;
        }
 
@@ -453,164 +453,164 @@ static void i915_restore_modeset_reg(struct drm_device *dev)
        }
 
        if (HAS_PCH_SPLIT(dev)) {
-               I915_WRITE(PCH_DREF_CONTROL, dev_priv->savePCH_DREF_CONTROL);
-               I915_WRITE(DISP_ARB_CTL, dev_priv->saveDISP_ARB_CTL);
+               I915_WRITE(PCH_DREF_CONTROL, dev_priv->regfile.savePCH_DREF_CONTROL);
+               I915_WRITE(DISP_ARB_CTL, dev_priv->regfile.saveDISP_ARB_CTL);
        }
 
        /* Pipe & plane A info */
        /* Prime the clock */
-       if (dev_priv->saveDPLL_A & DPLL_VCO_ENABLE) {
-               I915_WRITE(dpll_a_reg, dev_priv->saveDPLL_A &
+       if (dev_priv->regfile.saveDPLL_A & DPLL_VCO_ENABLE) {
+               I915_WRITE(dpll_a_reg, dev_priv->regfile.saveDPLL_A &
                           ~DPLL_VCO_ENABLE);
                POSTING_READ(dpll_a_reg);
                udelay(150);
        }
-       I915_WRITE(fpa0_reg, dev_priv->saveFPA0);
-       I915_WRITE(fpa1_reg, dev_priv->saveFPA1);
+       I915_WRITE(fpa0_reg, dev_priv->regfile.saveFPA0);
+       I915_WRITE(fpa1_reg, dev_priv->regfile.saveFPA1);
        /* Actually enable it */
-       I915_WRITE(dpll_a_reg, dev_priv->saveDPLL_A);
+       I915_WRITE(dpll_a_reg, dev_priv->regfile.saveDPLL_A);
        POSTING_READ(dpll_a_reg);
        udelay(150);
        if (INTEL_INFO(dev)->gen >= 4 && !HAS_PCH_SPLIT(dev)) {
-               I915_WRITE(_DPLL_A_MD, dev_priv->saveDPLL_A_MD);
+               I915_WRITE(_DPLL_A_MD, dev_priv->regfile.saveDPLL_A_MD);
                POSTING_READ(_DPLL_A_MD);
        }
        udelay(150);
 
        /* Restore mode */
-       I915_WRITE(_HTOTAL_A, dev_priv->saveHTOTAL_A);
-       I915_WRITE(_HBLANK_A, dev_priv->saveHBLANK_A);
-       I915_WRITE(_HSYNC_A, dev_priv->saveHSYNC_A);
-       I915_WRITE(_VTOTAL_A, dev_priv->saveVTOTAL_A);
-       I915_WRITE(_VBLANK_A, dev_priv->saveVBLANK_A);
-       I915_WRITE(_VSYNC_A, dev_priv->saveVSYNC_A);
+       I915_WRITE(_HTOTAL_A, dev_priv->regfile.saveHTOTAL_A);
+       I915_WRITE(_HBLANK_A, dev_priv->regfile.saveHBLANK_A);
+       I915_WRITE(_HSYNC_A, dev_priv->regfile.saveHSYNC_A);
+       I915_WRITE(_VTOTAL_A, dev_priv->regfile.saveVTOTAL_A);
+       I915_WRITE(_VBLANK_A, dev_priv->regfile.saveVBLANK_A);
+       I915_WRITE(_VSYNC_A, dev_priv->regfile.saveVSYNC_A);
        if (!HAS_PCH_SPLIT(dev))
-               I915_WRITE(_BCLRPAT_A, dev_priv->saveBCLRPAT_A);
+               I915_WRITE(_BCLRPAT_A, dev_priv->regfile.saveBCLRPAT_A);
 
        if (HAS_PCH_SPLIT(dev)) {
-               I915_WRITE(_PIPEA_DATA_M1, dev_priv->savePIPEA_DATA_M1);
-               I915_WRITE(_PIPEA_DATA_N1, dev_priv->savePIPEA_DATA_N1);
-               I915_WRITE(_PIPEA_LINK_M1, dev_priv->savePIPEA_LINK_M1);
-               I915_WRITE(_PIPEA_LINK_N1, dev_priv->savePIPEA_LINK_N1);
+               I915_WRITE(_PIPEA_DATA_M1, dev_priv->regfile.savePIPEA_DATA_M1);
+               I915_WRITE(_PIPEA_DATA_N1, dev_priv->regfile.savePIPEA_DATA_N1);
+               I915_WRITE(_PIPEA_LINK_M1, dev_priv->regfile.savePIPEA_LINK_M1);
+               I915_WRITE(_PIPEA_LINK_N1, dev_priv->regfile.savePIPEA_LINK_N1);
 
-               I915_WRITE(_FDI_RXA_CTL, dev_priv->saveFDI_RXA_CTL);
-               I915_WRITE(_FDI_TXA_CTL, dev_priv->saveFDI_TXA_CTL);
+               I915_WRITE(_FDI_RXA_CTL, dev_priv->regfile.saveFDI_RXA_CTL);
+               I915_WRITE(_FDI_TXA_CTL, dev_priv->regfile.saveFDI_TXA_CTL);
 
-               I915_WRITE(_PFA_CTL_1, dev_priv->savePFA_CTL_1);
-               I915_WRITE(_PFA_WIN_SZ, dev_priv->savePFA_WIN_SZ);
-               I915_WRITE(_PFA_WIN_POS, dev_priv->savePFA_WIN_POS);
+               I915_WRITE(_PFA_CTL_1, dev_priv->regfile.savePFA_CTL_1);
+               I915_WRITE(_PFA_WIN_SZ, dev_priv->regfile.savePFA_WIN_SZ);
+               I915_WRITE(_PFA_WIN_POS, dev_priv->regfile.savePFA_WIN_POS);
 
-               I915_WRITE(_TRANSACONF, dev_priv->saveTRANSACONF);
-               I915_WRITE(_TRANS_HTOTAL_A, dev_priv->saveTRANS_HTOTAL_A);
-               I915_WRITE(_TRANS_HBLANK_A, dev_priv->saveTRANS_HBLANK_A);
-               I915_WRITE(_TRANS_HSYNC_A, dev_priv->saveTRANS_HSYNC_A);
-               I915_WRITE(_TRANS_VTOTAL_A, dev_priv->saveTRANS_VTOTAL_A);
-               I915_WRITE(_TRANS_VBLANK_A, dev_priv->saveTRANS_VBLANK_A);
-               I915_WRITE(_TRANS_VSYNC_A, dev_priv->saveTRANS_VSYNC_A);
+               I915_WRITE(_TRANSACONF, dev_priv->regfile.saveTRANSACONF);
+               I915_WRITE(_TRANS_HTOTAL_A, dev_priv->regfile.saveTRANS_HTOTAL_A);
+               I915_WRITE(_TRANS_HBLANK_A, dev_priv->regfile.saveTRANS_HBLANK_A);
+               I915_WRITE(_TRANS_HSYNC_A, dev_priv->regfile.saveTRANS_HSYNC_A);
+               I915_WRITE(_TRANS_VTOTAL_A, dev_priv->regfile.saveTRANS_VTOTAL_A);
+               I915_WRITE(_TRANS_VBLANK_A, dev_priv->regfile.saveTRANS_VBLANK_A);
+               I915_WRITE(_TRANS_VSYNC_A, dev_priv->regfile.saveTRANS_VSYNC_A);
        }
 
        /* Restore plane info */
-       I915_WRITE(_DSPASIZE, dev_priv->saveDSPASIZE);
-       I915_WRITE(_DSPAPOS, dev_priv->saveDSPAPOS);
-       I915_WRITE(_PIPEASRC, dev_priv->savePIPEASRC);
-       I915_WRITE(_DSPAADDR, dev_priv->saveDSPAADDR);
-       I915_WRITE(_DSPASTRIDE, dev_priv->saveDSPASTRIDE);
+       I915_WRITE(_DSPASIZE, dev_priv->regfile.saveDSPASIZE);
+       I915_WRITE(_DSPAPOS, dev_priv->regfile.saveDSPAPOS);
+       I915_WRITE(_PIPEASRC, dev_priv->regfile.savePIPEASRC);
+       I915_WRITE(_DSPAADDR, dev_priv->regfile.saveDSPAADDR);
+       I915_WRITE(_DSPASTRIDE, dev_priv->regfile.saveDSPASTRIDE);
        if (INTEL_INFO(dev)->gen >= 4) {
-               I915_WRITE(_DSPASURF, dev_priv->saveDSPASURF);
-               I915_WRITE(_DSPATILEOFF, dev_priv->saveDSPATILEOFF);
+               I915_WRITE(_DSPASURF, dev_priv->regfile.saveDSPASURF);
+               I915_WRITE(_DSPATILEOFF, dev_priv->regfile.saveDSPATILEOFF);
        }
 
-       I915_WRITE(_PIPEACONF, dev_priv->savePIPEACONF);
+       I915_WRITE(_PIPEACONF, dev_priv->regfile.savePIPEACONF);
 
        i915_restore_palette(dev, PIPE_A);
        /* Enable the plane */
-       I915_WRITE(_DSPACNTR, dev_priv->saveDSPACNTR);
+       I915_WRITE(_DSPACNTR, dev_priv->regfile.saveDSPACNTR);
        I915_WRITE(_DSPAADDR, I915_READ(_DSPAADDR));
 
        /* Pipe & plane B info */
-       if (dev_priv->saveDPLL_B & DPLL_VCO_ENABLE) {
-               I915_WRITE(dpll_b_reg, dev_priv->saveDPLL_B &
+       if (dev_priv->regfile.saveDPLL_B & DPLL_VCO_ENABLE) {
+               I915_WRITE(dpll_b_reg, dev_priv->regfile.saveDPLL_B &
                           ~DPLL_VCO_ENABLE);
                POSTING_READ(dpll_b_reg);
                udelay(150);
        }
-       I915_WRITE(fpb0_reg, dev_priv->saveFPB0);
-       I915_WRITE(fpb1_reg, dev_priv->saveFPB1);
+       I915_WRITE(fpb0_reg, dev_priv->regfile.saveFPB0);
+       I915_WRITE(fpb1_reg, dev_priv->regfile.saveFPB1);
        /* Actually enable it */
-       I915_WRITE(dpll_b_reg, dev_priv->saveDPLL_B);
+       I915_WRITE(dpll_b_reg, dev_priv->regfile.saveDPLL_B);
        POSTING_READ(dpll_b_reg);
        udelay(150);
        if (INTEL_INFO(dev)->gen >= 4 && !HAS_PCH_SPLIT(dev)) {
-               I915_WRITE(_DPLL_B_MD, dev_priv->saveDPLL_B_MD);
+               I915_WRITE(_DPLL_B_MD, dev_priv->regfile.saveDPLL_B_MD);
                POSTING_READ(_DPLL_B_MD);
        }
        udelay(150);
 
        /* Restore mode */
-       I915_WRITE(_HTOTAL_B, dev_priv->saveHTOTAL_B);
-       I915_WRITE(_HBLANK_B, dev_priv->saveHBLANK_B);
-       I915_WRITE(_HSYNC_B, dev_priv->saveHSYNC_B);
-       I915_WRITE(_VTOTAL_B, dev_priv->saveVTOTAL_B);
-       I915_WRITE(_VBLANK_B, dev_priv->saveVBLANK_B);
-       I915_WRITE(_VSYNC_B, dev_priv->saveVSYNC_B);
+       I915_WRITE(_HTOTAL_B, dev_priv->regfile.saveHTOTAL_B);
+       I915_WRITE(_HBLANK_B, dev_priv->regfile.saveHBLANK_B);
+       I915_WRITE(_HSYNC_B, dev_priv->regfile.saveHSYNC_B);
+       I915_WRITE(_VTOTAL_B, dev_priv->regfile.saveVTOTAL_B);
+       I915_WRITE(_VBLANK_B, dev_priv->regfile.saveVBLANK_B);
+       I915_WRITE(_VSYNC_B, dev_priv->regfile.saveVSYNC_B);
        if (!HAS_PCH_SPLIT(dev))
-               I915_WRITE(_BCLRPAT_B, dev_priv->saveBCLRPAT_B);
+               I915_WRITE(_BCLRPAT_B, dev_priv->regfile.saveBCLRPAT_B);
 
        if (HAS_PCH_SPLIT(dev)) {
-               I915_WRITE(_PIPEB_DATA_M1, dev_priv->savePIPEB_DATA_M1);
-               I915_WRITE(_PIPEB_DATA_N1, dev_priv->savePIPEB_DATA_N1);
-               I915_WRITE(_PIPEB_LINK_M1, dev_priv->savePIPEB_LINK_M1);
-               I915_WRITE(_PIPEB_LINK_N1, dev_priv->savePIPEB_LINK_N1);
+               I915_WRITE(_PIPEB_DATA_M1, dev_priv->regfile.savePIPEB_DATA_M1);
+               I915_WRITE(_PIPEB_DATA_N1, dev_priv->regfile.savePIPEB_DATA_N1);
+               I915_WRITE(_PIPEB_LINK_M1, dev_priv->regfile.savePIPEB_LINK_M1);
+               I915_WRITE(_PIPEB_LINK_N1, dev_priv->regfile.savePIPEB_LINK_N1);
 
-               I915_WRITE(_FDI_RXB_CTL, dev_priv->saveFDI_RXB_CTL);
-               I915_WRITE(_FDI_TXB_CTL, dev_priv->saveFDI_TXB_CTL);
+               I915_WRITE(_FDI_RXB_CTL, dev_priv->regfile.saveFDI_RXB_CTL);
+               I915_WRITE(_FDI_TXB_CTL, dev_priv->regfile.saveFDI_TXB_CTL);
 
-               I915_WRITE(_PFB_CTL_1, dev_priv->savePFB_CTL_1);
-               I915_WRITE(_PFB_WIN_SZ, dev_priv->savePFB_WIN_SZ);
-               I915_WRITE(_PFB_WIN_POS, dev_priv->savePFB_WIN_POS);
+               I915_WRITE(_PFB_CTL_1, dev_priv->regfile.savePFB_CTL_1);
+               I915_WRITE(_PFB_WIN_SZ, dev_priv->regfile.savePFB_WIN_SZ);
+               I915_WRITE(_PFB_WIN_POS, dev_priv->regfile.savePFB_WIN_POS);
 
-               I915_WRITE(_TRANSBCONF, dev_priv->saveTRANSBCONF);
-               I915_WRITE(_TRANS_HTOTAL_B, dev_priv->saveTRANS_HTOTAL_B);
-               I915_WRITE(_TRANS_HBLANK_B, dev_priv->saveTRANS_HBLANK_B);
-               I915_WRITE(_TRANS_HSYNC_B, dev_priv->saveTRANS_HSYNC_B);
-               I915_WRITE(_TRANS_VTOTAL_B, dev_priv->saveTRANS_VTOTAL_B);
-               I915_WRITE(_TRANS_VBLANK_B, dev_priv->saveTRANS_VBLANK_B);
-               I915_WRITE(_TRANS_VSYNC_B, dev_priv->saveTRANS_VSYNC_B);
+               I915_WRITE(_TRANSBCONF, dev_priv->regfile.saveTRANSBCONF);
+               I915_WRITE(_TRANS_HTOTAL_B, dev_priv->regfile.saveTRANS_HTOTAL_B);
+               I915_WRITE(_TRANS_HBLANK_B, dev_priv->regfile.saveTRANS_HBLANK_B);
+               I915_WRITE(_TRANS_HSYNC_B, dev_priv->regfile.saveTRANS_HSYNC_B);
+               I915_WRITE(_TRANS_VTOTAL_B, dev_priv->regfile.saveTRANS_VTOTAL_B);
+               I915_WRITE(_TRANS_VBLANK_B, dev_priv->regfile.saveTRANS_VBLANK_B);
+               I915_WRITE(_TRANS_VSYNC_B, dev_priv->regfile.saveTRANS_VSYNC_B);
        }
 
        /* Restore plane info */
-       I915_WRITE(_DSPBSIZE, dev_priv->saveDSPBSIZE);
-       I915_WRITE(_DSPBPOS, dev_priv->saveDSPBPOS);
-       I915_WRITE(_PIPEBSRC, dev_priv->savePIPEBSRC);
-       I915_WRITE(_DSPBADDR, dev_priv->saveDSPBADDR);
-       I915_WRITE(_DSPBSTRIDE, dev_priv->saveDSPBSTRIDE);
+       I915_WRITE(_DSPBSIZE, dev_priv->regfile.saveDSPBSIZE);
+       I915_WRITE(_DSPBPOS, dev_priv->regfile.saveDSPBPOS);
+       I915_WRITE(_PIPEBSRC, dev_priv->regfile.savePIPEBSRC);
+       I915_WRITE(_DSPBADDR, dev_priv->regfile.saveDSPBADDR);
+       I915_WRITE(_DSPBSTRIDE, dev_priv->regfile.saveDSPBSTRIDE);
        if (INTEL_INFO(dev)->gen >= 4) {
-               I915_WRITE(_DSPBSURF, dev_priv->saveDSPBSURF);
-               I915_WRITE(_DSPBTILEOFF, dev_priv->saveDSPBTILEOFF);
+               I915_WRITE(_DSPBSURF, dev_priv->regfile.saveDSPBSURF);
+               I915_WRITE(_DSPBTILEOFF, dev_priv->regfile.saveDSPBTILEOFF);
        }
 
-       I915_WRITE(_PIPEBCONF, dev_priv->savePIPEBCONF);
+       I915_WRITE(_PIPEBCONF, dev_priv->regfile.savePIPEBCONF);
 
        i915_restore_palette(dev, PIPE_B);
        /* Enable the plane */
-       I915_WRITE(_DSPBCNTR, dev_priv->saveDSPBCNTR);
+       I915_WRITE(_DSPBCNTR, dev_priv->regfile.saveDSPBCNTR);
        I915_WRITE(_DSPBADDR, I915_READ(_DSPBADDR));
 
        /* Cursor state */
-       I915_WRITE(_CURAPOS, dev_priv->saveCURAPOS);
-       I915_WRITE(_CURACNTR, dev_priv->saveCURACNTR);
-       I915_WRITE(_CURABASE, dev_priv->saveCURABASE);
-       I915_WRITE(_CURBPOS, dev_priv->saveCURBPOS);
-       I915_WRITE(_CURBCNTR, dev_priv->saveCURBCNTR);
-       I915_WRITE(_CURBBASE, dev_priv->saveCURBBASE);
+       I915_WRITE(_CURAPOS, dev_priv->regfile.saveCURAPOS);
+       I915_WRITE(_CURACNTR, dev_priv->regfile.saveCURACNTR);
+       I915_WRITE(_CURABASE, dev_priv->regfile.saveCURABASE);
+       I915_WRITE(_CURBPOS, dev_priv->regfile.saveCURBPOS);
+       I915_WRITE(_CURBCNTR, dev_priv->regfile.saveCURBCNTR);
+       I915_WRITE(_CURBBASE, dev_priv->regfile.saveCURBBASE);
        if (IS_GEN2(dev))
-               I915_WRITE(CURSIZE, dev_priv->saveCURSIZE);
+               I915_WRITE(CURSIZE, dev_priv->regfile.saveCURSIZE);
 
        /* CRT state */
        if (HAS_PCH_SPLIT(dev))
-               I915_WRITE(PCH_ADPA, dev_priv->saveADPA);
+               I915_WRITE(PCH_ADPA, dev_priv->regfile.saveADPA);
        else
-               I915_WRITE(ADPA, dev_priv->saveADPA);
+               I915_WRITE(ADPA, dev_priv->regfile.saveADPA);
 
        return;
 }
@@ -620,84 +620,84 @@ static void i915_save_display(struct drm_device *dev)
        struct drm_i915_private *dev_priv = dev->dev_private;
 
        /* Display arbitration control */
-       dev_priv->saveDSPARB = I915_READ(DSPARB);
+       dev_priv->regfile.saveDSPARB = I915_READ(DSPARB);
 
        /* This is only meaningful in non-KMS mode */
-       /* Don't save them in KMS mode */
+       /* Don't regfile.save them in KMS mode */
        i915_save_modeset_reg(dev);
 
        /* LVDS state */
        if (HAS_PCH_SPLIT(dev)) {
-               dev_priv->savePP_CONTROL = I915_READ(PCH_PP_CONTROL);
-               dev_priv->saveBLC_PWM_CTL = I915_READ(BLC_PWM_PCH_CTL1);
-               dev_priv->saveBLC_PWM_CTL2 = I915_READ(BLC_PWM_PCH_CTL2);
-               dev_priv->saveBLC_CPU_PWM_CTL = I915_READ(BLC_PWM_CPU_CTL);
-               dev_priv->saveBLC_CPU_PWM_CTL2 = I915_READ(BLC_PWM_CPU_CTL2);
-               dev_priv->saveLVDS = I915_READ(PCH_LVDS);
+               dev_priv->regfile.savePP_CONTROL = I915_READ(PCH_PP_CONTROL);
+               dev_priv->regfile.saveBLC_PWM_CTL = I915_READ(BLC_PWM_PCH_CTL1);
+               dev_priv->regfile.saveBLC_PWM_CTL2 = I915_READ(BLC_PWM_PCH_CTL2);
+               dev_priv->regfile.saveBLC_CPU_PWM_CTL = I915_READ(BLC_PWM_CPU_CTL);
+               dev_priv->regfile.saveBLC_CPU_PWM_CTL2 = I915_READ(BLC_PWM_CPU_CTL2);
+               dev_priv->regfile.saveLVDS = I915_READ(PCH_LVDS);
        } else {
-               dev_priv->savePP_CONTROL = I915_READ(PP_CONTROL);
-               dev_priv->savePFIT_PGM_RATIOS = I915_READ(PFIT_PGM_RATIOS);
-               dev_priv->saveBLC_PWM_CTL = I915_READ(BLC_PWM_CTL);
-               dev_priv->saveBLC_HIST_CTL = I915_READ(BLC_HIST_CTL);
+               dev_priv->regfile.savePP_CONTROL = I915_READ(PP_CONTROL);
+               dev_priv->regfile.savePFIT_PGM_RATIOS = I915_READ(PFIT_PGM_RATIOS);
+               dev_priv->regfile.saveBLC_PWM_CTL = I915_READ(BLC_PWM_CTL);
+               dev_priv->regfile.saveBLC_HIST_CTL = I915_READ(BLC_HIST_CTL);
                if (INTEL_INFO(dev)->gen >= 4)
-                       dev_priv->saveBLC_PWM_CTL2 = I915_READ(BLC_PWM_CTL2);
+                       dev_priv->regfile.saveBLC_PWM_CTL2 = I915_READ(BLC_PWM_CTL2);
                if (IS_MOBILE(dev) && !IS_I830(dev))
-                       dev_priv->saveLVDS = I915_READ(LVDS);
+                       dev_priv->regfile.saveLVDS = I915_READ(LVDS);
        }
 
        if (!IS_I830(dev) && !IS_845G(dev) && !HAS_PCH_SPLIT(dev))
-               dev_priv->savePFIT_CONTROL = I915_READ(PFIT_CONTROL);
+               dev_priv->regfile.savePFIT_CONTROL = I915_READ(PFIT_CONTROL);
 
        if (HAS_PCH_SPLIT(dev)) {
-               dev_priv->savePP_ON_DELAYS = I915_READ(PCH_PP_ON_DELAYS);
-               dev_priv->savePP_OFF_DELAYS = I915_READ(PCH_PP_OFF_DELAYS);
-               dev_priv->savePP_DIVISOR = I915_READ(PCH_PP_DIVISOR);
+               dev_priv->regfile.savePP_ON_DELAYS = I915_READ(PCH_PP_ON_DELAYS);
+               dev_priv->regfile.savePP_OFF_DELAYS = I915_READ(PCH_PP_OFF_DELAYS);
+               dev_priv->regfile.savePP_DIVISOR = I915_READ(PCH_PP_DIVISOR);
        } else {
-               dev_priv->savePP_ON_DELAYS = I915_READ(PP_ON_DELAYS);
-               dev_priv->savePP_OFF_DELAYS = I915_READ(PP_OFF_DELAYS);
-               dev_priv->savePP_DIVISOR = I915_READ(PP_DIVISOR);
+               dev_priv->regfile.savePP_ON_DELAYS = I915_READ(PP_ON_DELAYS);
+               dev_priv->regfile.savePP_OFF_DELAYS = I915_READ(PP_OFF_DELAYS);
+               dev_priv->regfile.savePP_DIVISOR = I915_READ(PP_DIVISOR);
        }
 
        if (!drm_core_check_feature(dev, DRIVER_MODESET)) {
                /* Display Port state */
                if (SUPPORTS_INTEGRATED_DP(dev)) {
-                       dev_priv->saveDP_B = I915_READ(DP_B);
-                       dev_priv->saveDP_C = I915_READ(DP_C);
-                       dev_priv->saveDP_D = I915_READ(DP_D);
-                       dev_priv->savePIPEA_GMCH_DATA_M = I915_READ(_PIPEA_GMCH_DATA_M);
-                       dev_priv->savePIPEB_GMCH_DATA_M = I915_READ(_PIPEB_GMCH_DATA_M);
-                       dev_priv->savePIPEA_GMCH_DATA_N = I915_READ(_PIPEA_GMCH_DATA_N);
-                       dev_priv->savePIPEB_GMCH_DATA_N = I915_READ(_PIPEB_GMCH_DATA_N);
-                       dev_priv->savePIPEA_DP_LINK_M = I915_READ(_PIPEA_DP_LINK_M);
-                       dev_priv->savePIPEB_DP_LINK_M = I915_READ(_PIPEB_DP_LINK_M);
-                       dev_priv->savePIPEA_DP_LINK_N = I915_READ(_PIPEA_DP_LINK_N);
-                       dev_priv->savePIPEB_DP_LINK_N = I915_READ(_PIPEB_DP_LINK_N);
+                       dev_priv->regfile.saveDP_B = I915_READ(DP_B);
+                       dev_priv->regfile.saveDP_C = I915_READ(DP_C);
+                       dev_priv->regfile.saveDP_D = I915_READ(DP_D);
+                       dev_priv->regfile.savePIPEA_GMCH_DATA_M = I915_READ(_PIPEA_GMCH_DATA_M);
+                       dev_priv->regfile.savePIPEB_GMCH_DATA_M = I915_READ(_PIPEB_GMCH_DATA_M);
+                       dev_priv->regfile.savePIPEA_GMCH_DATA_N = I915_READ(_PIPEA_GMCH_DATA_N);
+                       dev_priv->regfile.savePIPEB_GMCH_DATA_N = I915_READ(_PIPEB_GMCH_DATA_N);
+                       dev_priv->regfile.savePIPEA_DP_LINK_M = I915_READ(_PIPEA_DP_LINK_M);
+                       dev_priv->regfile.savePIPEB_DP_LINK_M = I915_READ(_PIPEB_DP_LINK_M);
+                       dev_priv->regfile.savePIPEA_DP_LINK_N = I915_READ(_PIPEA_DP_LINK_N);
+                       dev_priv->regfile.savePIPEB_DP_LINK_N = I915_READ(_PIPEB_DP_LINK_N);
                }
-               /* FIXME: save TV & SDVO state */
+               /* FIXME: regfile.save TV & SDVO state */
        }
 
-       /* Only save FBC state on the platform that supports FBC */
+       /* Only regfile.save FBC state on the platform that supports FBC */
        if (I915_HAS_FBC(dev)) {
                if (HAS_PCH_SPLIT(dev)) {
-                       dev_priv->saveDPFC_CB_BASE = I915_READ(ILK_DPFC_CB_BASE);
+                       dev_priv->regfile.saveDPFC_CB_BASE = I915_READ(ILK_DPFC_CB_BASE);
                } else if (IS_GM45(dev)) {
-                       dev_priv->saveDPFC_CB_BASE = I915_READ(DPFC_CB_BASE);
+                       dev_priv->regfile.saveDPFC_CB_BASE = I915_READ(DPFC_CB_BASE);
                } else {
-                       dev_priv->saveFBC_CFB_BASE = I915_READ(FBC_CFB_BASE);
-                       dev_priv->saveFBC_LL_BASE = I915_READ(FBC_LL_BASE);
-                       dev_priv->saveFBC_CONTROL2 = I915_READ(FBC_CONTROL2);
-                       dev_priv->saveFBC_CONTROL = I915_READ(FBC_CONTROL);
+                       dev_priv->regfile.saveFBC_CFB_BASE = I915_READ(FBC_CFB_BASE);
+                       dev_priv->regfile.saveFBC_LL_BASE = I915_READ(FBC_LL_BASE);
+                       dev_priv->regfile.saveFBC_CONTROL2 = I915_READ(FBC_CONTROL2);
+                       dev_priv->regfile.saveFBC_CONTROL = I915_READ(FBC_CONTROL);
                }
        }
 
        /* VGA state */
-       dev_priv->saveVGA0 = I915_READ(VGA0);
-       dev_priv->saveVGA1 = I915_READ(VGA1);
-       dev_priv->saveVGA_PD = I915_READ(VGA_PD);
+       dev_priv->regfile.saveVGA0 = I915_READ(VGA0);
+       dev_priv->regfile.saveVGA1 = I915_READ(VGA1);
+       dev_priv->regfile.saveVGA_PD = I915_READ(VGA_PD);
        if (HAS_PCH_SPLIT(dev))
-               dev_priv->saveVGACNTRL = I915_READ(CPU_VGACNTRL);
+               dev_priv->regfile.saveVGACNTRL = I915_READ(CPU_VGACNTRL);
        else
-               dev_priv->saveVGACNTRL = I915_READ(VGACNTRL);
+               dev_priv->regfile.saveVGACNTRL = I915_READ(VGACNTRL);
 
        i915_save_vga(dev);
 }
@@ -707,19 +707,19 @@ static void i915_restore_display(struct drm_device *dev)
        struct drm_i915_private *dev_priv = dev->dev_private;
 
        /* Display arbitration */
-       I915_WRITE(DSPARB, dev_priv->saveDSPARB);
+       I915_WRITE(DSPARB, dev_priv->regfile.saveDSPARB);
 
        if (!drm_core_check_feature(dev, DRIVER_MODESET)) {
                /* Display port ratios (must be done before clock is set) */
                if (SUPPORTS_INTEGRATED_DP(dev)) {
-                       I915_WRITE(_PIPEA_GMCH_DATA_M, dev_priv->savePIPEA_GMCH_DATA_M);
-                       I915_WRITE(_PIPEB_GMCH_DATA_M, dev_priv->savePIPEB_GMCH_DATA_M);
-                       I915_WRITE(_PIPEA_GMCH_DATA_N, dev_priv->savePIPEA_GMCH_DATA_N);
-                       I915_WRITE(_PIPEB_GMCH_DATA_N, dev_priv->savePIPEB_GMCH_DATA_N);
-                       I915_WRITE(_PIPEA_DP_LINK_M, dev_priv->savePIPEA_DP_LINK_M);
-                       I915_WRITE(_PIPEB_DP_LINK_M, dev_priv->savePIPEB_DP_LINK_M);
-                       I915_WRITE(_PIPEA_DP_LINK_N, dev_priv->savePIPEA_DP_LINK_N);
-                       I915_WRITE(_PIPEB_DP_LINK_N, dev_priv->savePIPEB_DP_LINK_N);
+                       I915_WRITE(_PIPEA_GMCH_DATA_M, dev_priv->regfile.savePIPEA_GMCH_DATA_M);
+                       I915_WRITE(_PIPEB_GMCH_DATA_M, dev_priv->regfile.savePIPEB_GMCH_DATA_M);
+                       I915_WRITE(_PIPEA_GMCH_DATA_N, dev_priv->regfile.savePIPEA_GMCH_DATA_N);
+                       I915_WRITE(_PIPEB_GMCH_DATA_N, dev_priv->regfile.savePIPEB_GMCH_DATA_N);
+                       I915_WRITE(_PIPEA_DP_LINK_M, dev_priv->regfile.savePIPEA_DP_LINK_M);
+                       I915_WRITE(_PIPEB_DP_LINK_M, dev_priv->regfile.savePIPEB_DP_LINK_M);
+                       I915_WRITE(_PIPEA_DP_LINK_N, dev_priv->regfile.savePIPEA_DP_LINK_N);
+                       I915_WRITE(_PIPEB_DP_LINK_N, dev_priv->regfile.savePIPEB_DP_LINK_N);
                }
        }
 
@@ -729,46 +729,46 @@ static void i915_restore_display(struct drm_device *dev)
 
        /* LVDS state */
        if (INTEL_INFO(dev)->gen >= 4 && !HAS_PCH_SPLIT(dev))
-               I915_WRITE(BLC_PWM_CTL2, dev_priv->saveBLC_PWM_CTL2);
+               I915_WRITE(BLC_PWM_CTL2, dev_priv->regfile.saveBLC_PWM_CTL2);
 
        if (HAS_PCH_SPLIT(dev)) {
-               I915_WRITE(PCH_LVDS, dev_priv->saveLVDS);
+               I915_WRITE(PCH_LVDS, dev_priv->regfile.saveLVDS);
        } else if (IS_MOBILE(dev) && !IS_I830(dev))
-               I915_WRITE(LVDS, dev_priv->saveLVDS);
+               I915_WRITE(LVDS, dev_priv->regfile.saveLVDS);
 
        if (!IS_I830(dev) && !IS_845G(dev) && !HAS_PCH_SPLIT(dev))
-               I915_WRITE(PFIT_CONTROL, dev_priv->savePFIT_CONTROL);
+               I915_WRITE(PFIT_CONTROL, dev_priv->regfile.savePFIT_CONTROL);
 
        if (HAS_PCH_SPLIT(dev)) {
-               I915_WRITE(BLC_PWM_PCH_CTL1, dev_priv->saveBLC_PWM_CTL);
-               I915_WRITE(BLC_PWM_PCH_CTL2, dev_priv->saveBLC_PWM_CTL2);
+               I915_WRITE(BLC_PWM_PCH_CTL1, dev_priv->regfile.saveBLC_PWM_CTL);
+               I915_WRITE(BLC_PWM_PCH_CTL2, dev_priv->regfile.saveBLC_PWM_CTL2);
                /* NOTE: BLC_PWM_CPU_CTL must be written after BLC_PWM_CPU_CTL2;
                 * otherwise we get blank eDP screen after S3 on some machines
                 */
-               I915_WRITE(BLC_PWM_CPU_CTL2, dev_priv->saveBLC_CPU_PWM_CTL2);
-               I915_WRITE(BLC_PWM_CPU_CTL, dev_priv->saveBLC_CPU_PWM_CTL);
-               I915_WRITE(PCH_PP_ON_DELAYS, dev_priv->savePP_ON_DELAYS);
-               I915_WRITE(PCH_PP_OFF_DELAYS, dev_priv->savePP_OFF_DELAYS);
-               I915_WRITE(PCH_PP_DIVISOR, dev_priv->savePP_DIVISOR);
-               I915_WRITE(PCH_PP_CONTROL, dev_priv->savePP_CONTROL);
+               I915_WRITE(BLC_PWM_CPU_CTL2, dev_priv->regfile.saveBLC_CPU_PWM_CTL2);
+               I915_WRITE(BLC_PWM_CPU_CTL, dev_priv->regfile.saveBLC_CPU_PWM_CTL);
+               I915_WRITE(PCH_PP_ON_DELAYS, dev_priv->regfile.savePP_ON_DELAYS);
+               I915_WRITE(PCH_PP_OFF_DELAYS, dev_priv->regfile.savePP_OFF_DELAYS);
+               I915_WRITE(PCH_PP_DIVISOR, dev_priv->regfile.savePP_DIVISOR);
+               I915_WRITE(PCH_PP_CONTROL, dev_priv->regfile.savePP_CONTROL);
                I915_WRITE(RSTDBYCTL,
-                          dev_priv->saveMCHBAR_RENDER_STANDBY);
+                          dev_priv->regfile.saveMCHBAR_RENDER_STANDBY);
        } else {
-               I915_WRITE(PFIT_PGM_RATIOS, dev_priv->savePFIT_PGM_RATIOS);
-               I915_WRITE(BLC_PWM_CTL, dev_priv->saveBLC_PWM_CTL);
-               I915_WRITE(BLC_HIST_CTL, dev_priv->saveBLC_HIST_CTL);
-               I915_WRITE(PP_ON_DELAYS, dev_priv->savePP_ON_DELAYS);
-               I915_WRITE(PP_OFF_DELAYS, dev_priv->savePP_OFF_DELAYS);
-               I915_WRITE(PP_DIVISOR, dev_priv->savePP_DIVISOR);
-               I915_WRITE(PP_CONTROL, dev_priv->savePP_CONTROL);
+               I915_WRITE(PFIT_PGM_RATIOS, dev_priv->regfile.savePFIT_PGM_RATIOS);
+               I915_WRITE(BLC_PWM_CTL, dev_priv->regfile.saveBLC_PWM_CTL);
+               I915_WRITE(BLC_HIST_CTL, dev_priv->regfile.saveBLC_HIST_CTL);
+               I915_WRITE(PP_ON_DELAYS, dev_priv->regfile.savePP_ON_DELAYS);
+               I915_WRITE(PP_OFF_DELAYS, dev_priv->regfile.savePP_OFF_DELAYS);
+               I915_WRITE(PP_DIVISOR, dev_priv->regfile.savePP_DIVISOR);
+               I915_WRITE(PP_CONTROL, dev_priv->regfile.savePP_CONTROL);
        }
 
        if (!drm_core_check_feature(dev, DRIVER_MODESET)) {
                /* Display Port state */
                if (SUPPORTS_INTEGRATED_DP(dev)) {
-                       I915_WRITE(DP_B, dev_priv->saveDP_B);
-                       I915_WRITE(DP_C, dev_priv->saveDP_C);
-                       I915_WRITE(DP_D, dev_priv->saveDP_D);
+                       I915_WRITE(DP_B, dev_priv->regfile.saveDP_B);
+                       I915_WRITE(DP_C, dev_priv->regfile.saveDP_C);
+                       I915_WRITE(DP_D, dev_priv->regfile.saveDP_D);
                }
                /* FIXME: restore TV & SDVO state */
        }
@@ -777,25 +777,25 @@ static void i915_restore_display(struct drm_device *dev)
        intel_disable_fbc(dev);
        if (I915_HAS_FBC(dev)) {
                if (HAS_PCH_SPLIT(dev)) {
-                       I915_WRITE(ILK_DPFC_CB_BASE, dev_priv->saveDPFC_CB_BASE);
+                       I915_WRITE(ILK_DPFC_CB_BASE, dev_priv->regfile.saveDPFC_CB_BASE);
                } else if (IS_GM45(dev)) {
-                       I915_WRITE(DPFC_CB_BASE, dev_priv->saveDPFC_CB_BASE);
+                       I915_WRITE(DPFC_CB_BASE, dev_priv->regfile.saveDPFC_CB_BASE);
                } else {
-                       I915_WRITE(FBC_CFB_BASE, dev_priv->saveFBC_CFB_BASE);
-                       I915_WRITE(FBC_LL_BASE, dev_priv->saveFBC_LL_BASE);
-                       I915_WRITE(FBC_CONTROL2, dev_priv->saveFBC_CONTROL2);
-                       I915_WRITE(FBC_CONTROL, dev_priv->saveFBC_CONTROL);
+                       I915_WRITE(FBC_CFB_BASE, dev_priv->regfile.saveFBC_CFB_BASE);
+                       I915_WRITE(FBC_LL_BASE, dev_priv->regfile.saveFBC_LL_BASE);
+                       I915_WRITE(FBC_CONTROL2, dev_priv->regfile.saveFBC_CONTROL2);
+                       I915_WRITE(FBC_CONTROL, dev_priv->regfile.saveFBC_CONTROL);
                }
        }
        /* VGA state */
        if (HAS_PCH_SPLIT(dev))
-               I915_WRITE(CPU_VGACNTRL, dev_priv->saveVGACNTRL);
+               I915_WRITE(CPU_VGACNTRL, dev_priv->regfile.saveVGACNTRL);
        else
-               I915_WRITE(VGACNTRL, dev_priv->saveVGACNTRL);
+               I915_WRITE(VGACNTRL, dev_priv->regfile.saveVGACNTRL);
 
-       I915_WRITE(VGA0, dev_priv->saveVGA0);
-       I915_WRITE(VGA1, dev_priv->saveVGA1);
-       I915_WRITE(VGA_PD, dev_priv->saveVGA_PD);
+       I915_WRITE(VGA0, dev_priv->regfile.saveVGA0);
+       I915_WRITE(VGA1, dev_priv->regfile.saveVGA1);
+       I915_WRITE(VGA_PD, dev_priv->regfile.saveVGA_PD);
        POSTING_READ(VGA_PD);
        udelay(150);
 
@@ -807,49 +807,49 @@ int i915_save_state(struct drm_device *dev)
        struct drm_i915_private *dev_priv = dev->dev_private;
        int i;
 
-       pci_read_config_byte(dev->pdev, LBB, &dev_priv->saveLBB);
+       pci_read_config_byte(dev->pdev, LBB, &dev_priv->regfile.saveLBB);
 
        mutex_lock(&dev->struct_mutex);
 
        /* Hardware status page */
        if (!drm_core_check_feature(dev, DRIVER_MODESET))
-               dev_priv->saveHWS = I915_READ(HWS_PGA);
+               dev_priv->regfile.saveHWS = I915_READ(HWS_PGA);
 
        i915_save_display(dev);
 
        if (!drm_core_check_feature(dev, DRIVER_MODESET)) {
                /* Interrupt state */
                if (HAS_PCH_SPLIT(dev)) {
-                       dev_priv->saveDEIER = I915_READ(DEIER);
-                       dev_priv->saveDEIMR = I915_READ(DEIMR);
-                       dev_priv->saveGTIER = I915_READ(GTIER);
-                       dev_priv->saveGTIMR = I915_READ(GTIMR);
-                       dev_priv->saveFDI_RXA_IMR = I915_READ(_FDI_RXA_IMR);
-                       dev_priv->saveFDI_RXB_IMR = I915_READ(_FDI_RXB_IMR);
-                       dev_priv->saveMCHBAR_RENDER_STANDBY =
+                       dev_priv->regfile.saveDEIER = I915_READ(DEIER);
+                       dev_priv->regfile.saveDEIMR = I915_READ(DEIMR);
+                       dev_priv->regfile.saveGTIER = I915_READ(GTIER);
+                       dev_priv->regfile.saveGTIMR = I915_READ(GTIMR);
+                       dev_priv->regfile.saveFDI_RXA_IMR = I915_READ(_FDI_RXA_IMR);
+                       dev_priv->regfile.saveFDI_RXB_IMR = I915_READ(_FDI_RXB_IMR);
+                       dev_priv->regfile.saveMCHBAR_RENDER_STANDBY =
                                I915_READ(RSTDBYCTL);
-                       dev_priv->savePCH_PORT_HOTPLUG = I915_READ(PCH_PORT_HOTPLUG);
+                       dev_priv->regfile.savePCH_PORT_HOTPLUG = I915_READ(PCH_PORT_HOTPLUG);
                } else {
-                       dev_priv->saveIER = I915_READ(IER);
-                       dev_priv->saveIMR = I915_READ(IMR);
+                       dev_priv->regfile.saveIER = I915_READ(IER);
+                       dev_priv->regfile.saveIMR = I915_READ(IMR);
                }
        }
 
        intel_disable_gt_powersave(dev);
 
        /* Cache mode state */
-       dev_priv->saveCACHE_MODE_0 = I915_READ(CACHE_MODE_0);
+       dev_priv->regfile.saveCACHE_MODE_0 = I915_READ(CACHE_MODE_0);
 
        /* Memory Arbitration state */
-       dev_priv->saveMI_ARB_STATE = I915_READ(MI_ARB_STATE);
+       dev_priv->regfile.saveMI_ARB_STATE = I915_READ(MI_ARB_STATE);
 
        /* Scratch space */
        for (i = 0; i < 16; i++) {
-               dev_priv->saveSWF0[i] = I915_READ(SWF00 + (i << 2));
-               dev_priv->saveSWF1[i] = I915_READ(SWF10 + (i << 2));
+               dev_priv->regfile.saveSWF0[i] = I915_READ(SWF00 + (i << 2));
+               dev_priv->regfile.saveSWF1[i] = I915_READ(SWF10 + (i << 2));
        }
        for (i = 0; i < 3; i++)
-               dev_priv->saveSWF2[i] = I915_READ(SWF30 + (i << 2));
+               dev_priv->regfile.saveSWF2[i] = I915_READ(SWF30 + (i << 2));
 
        mutex_unlock(&dev->struct_mutex);
 
@@ -861,44 +861,44 @@ int i915_restore_state(struct drm_device *dev)
        struct drm_i915_private *dev_priv = dev->dev_private;
        int i;
 
-       pci_write_config_byte(dev->pdev, LBB, dev_priv->saveLBB);
+       pci_write_config_byte(dev->pdev, LBB, dev_priv->regfile.saveLBB);
 
        mutex_lock(&dev->struct_mutex);
 
        /* Hardware status page */
        if (!drm_core_check_feature(dev, DRIVER_MODESET))
-               I915_WRITE(HWS_PGA, dev_priv->saveHWS);
+               I915_WRITE(HWS_PGA, dev_priv->regfile.saveHWS);
 
        i915_restore_display(dev);
 
        if (!drm_core_check_feature(dev, DRIVER_MODESET)) {
                /* Interrupt state */
                if (HAS_PCH_SPLIT(dev)) {
-                       I915_WRITE(DEIER, dev_priv->saveDEIER);
-                       I915_WRITE(DEIMR, dev_priv->saveDEIMR);
-                       I915_WRITE(GTIER, dev_priv->saveGTIER);
-                       I915_WRITE(GTIMR, dev_priv->saveGTIMR);
-                       I915_WRITE(_FDI_RXA_IMR, dev_priv->saveFDI_RXA_IMR);
-                       I915_WRITE(_FDI_RXB_IMR, dev_priv->saveFDI_RXB_IMR);
-                       I915_WRITE(PCH_PORT_HOTPLUG, dev_priv->savePCH_PORT_HOTPLUG);
+                       I915_WRITE(DEIER, dev_priv->regfile.saveDEIER);
+                       I915_WRITE(DEIMR, dev_priv->regfile.saveDEIMR);
+                       I915_WRITE(GTIER, dev_priv->regfile.saveGTIER);
+                       I915_WRITE(GTIMR, dev_priv->regfile.saveGTIMR);
+                       I915_WRITE(_FDI_RXA_IMR, dev_priv->regfile.saveFDI_RXA_IMR);
+                       I915_WRITE(_FDI_RXB_IMR, dev_priv->regfile.saveFDI_RXB_IMR);
+                       I915_WRITE(PCH_PORT_HOTPLUG, dev_priv->regfile.savePCH_PORT_HOTPLUG);
                } else {
-                       I915_WRITE(IER, dev_priv->saveIER);
-                       I915_WRITE(IMR, dev_priv->saveIMR);
+                       I915_WRITE(IER, dev_priv->regfile.saveIER);
+                       I915_WRITE(IMR, dev_priv->regfile.saveIMR);
                }
        }
 
        /* Cache mode state */
-       I915_WRITE(CACHE_MODE_0, dev_priv->saveCACHE_MODE_0 | 0xffff0000);
+       I915_WRITE(CACHE_MODE_0, dev_priv->regfile.saveCACHE_MODE_0 | 0xffff0000);
 
        /* Memory arbitration state */
-       I915_WRITE(MI_ARB_STATE, dev_priv->saveMI_ARB_STATE | 0xffff0000);
+       I915_WRITE(MI_ARB_STATE, dev_priv->regfile.saveMI_ARB_STATE | 0xffff0000);
 
        for (i = 0; i < 16; i++) {
-               I915_WRITE(SWF00 + (i << 2), dev_priv->saveSWF0[i]);
-               I915_WRITE(SWF10 + (i << 2), dev_priv->saveSWF1[i]);
+               I915_WRITE(SWF00 + (i << 2), dev_priv->regfile.saveSWF0[i]);
+               I915_WRITE(SWF10 + (i << 2), dev_priv->regfile.saveSWF1[i]);
        }
        for (i = 0; i < 3; i++)
-               I915_WRITE(SWF30 + (i << 2), dev_priv->saveSWF2[i]);
+               I915_WRITE(SWF30 + (i << 2), dev_priv->regfile.saveSWF2[i]);
 
        mutex_unlock(&dev->struct_mutex);
 
index e91a0bbc5bca00446f5d3f488a3bbab4372ab452..856ab5dec18b4e874e1787082b0f684f2d70dbf2 100644 (file)
@@ -138,24 +138,24 @@ static u32 i915_read_blc_pwm_ctl(struct drm_i915_private *dev_priv)
 
        if (HAS_PCH_SPLIT(dev_priv->dev)) {
                val = I915_READ(BLC_PWM_PCH_CTL2);
-               if (dev_priv->saveBLC_PWM_CTL2 == 0) {
-                       dev_priv->saveBLC_PWM_CTL2 = val;
+               if (dev_priv->regfile.saveBLC_PWM_CTL2 == 0) {
+                       dev_priv->regfile.saveBLC_PWM_CTL2 = val;
                } else if (val == 0) {
                        I915_WRITE(BLC_PWM_PCH_CTL2,
-                                  dev_priv->saveBLC_PWM_CTL2);
-                       val = dev_priv->saveBLC_PWM_CTL2;
+                                  dev_priv->regfile.saveBLC_PWM_CTL2);
+                       val = dev_priv->regfile.saveBLC_PWM_CTL2;
                }
        } else {
                val = I915_READ(BLC_PWM_CTL);
-               if (dev_priv->saveBLC_PWM_CTL == 0) {
-                       dev_priv->saveBLC_PWM_CTL = val;
-                       dev_priv->saveBLC_PWM_CTL2 = I915_READ(BLC_PWM_CTL2);
+               if (dev_priv->regfile.saveBLC_PWM_CTL == 0) {
+                       dev_priv->regfile.saveBLC_PWM_CTL = val;
+                       dev_priv->regfile.saveBLC_PWM_CTL2 = I915_READ(BLC_PWM_CTL2);
                } else if (val == 0) {
                        I915_WRITE(BLC_PWM_CTL,
-                                  dev_priv->saveBLC_PWM_CTL);
+                                  dev_priv->regfile.saveBLC_PWM_CTL);
                        I915_WRITE(BLC_PWM_CTL2,
-                                  dev_priv->saveBLC_PWM_CTL2);
-                       val = dev_priv->saveBLC_PWM_CTL;
+                                  dev_priv->regfile.saveBLC_PWM_CTL2);
+                       val = dev_priv->regfile.saveBLC_PWM_CTL;
                }
        }