stm class: Use a signed return type for stm_find_master_chan
authorLucas Tanure <tanure@linux.com>
Mon, 15 Feb 2016 17:11:51 +0000 (19:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 20 Feb 2016 22:09:14 +0000 (14:09 -0800)
The return type "unsigned int" was used by the stm_find_master_chan function
despite of the aspect that it will eventually return a negative error code.

Done with the help of Coccinelle.

Signed-off-by: Lucas Tanure <tanure@linux.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/stm/core.c

index aef8ddb24451e3866173f582cb3b582d3d612273..cdec240bd6b6db422ee2ea2fa51585b13dc476bf 100644 (file)
@@ -233,7 +233,7 @@ static int find_free_channels(unsigned long *bitmap, unsigned int start,
        return -1;
 }
 
-static unsigned int
+static int
 stm_find_master_chan(struct stm_device *stm, unsigned int width,
                     unsigned int *mstart, unsigned int mend,
                     unsigned int *cstart, unsigned int cend)
@@ -293,7 +293,7 @@ static int stm_output_assign(struct stm_device *stm, unsigned int width,
                goto unlock;
 
        ret = stm_find_master_chan(stm, width, &midx, mend, &cidx, cend);
-       if (ret)
+       if (ret < 0)
                goto unlock;
 
        output->master = midx;