libfc: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
authorAndreea-Cristina Bernat <bernat.ada@gmail.com>
Mon, 18 Aug 2014 14:56:22 +0000 (17:56 +0300)
committerChristoph Hellwig <hch@lst.de>
Tue, 30 Sep 2014 07:28:36 +0000 (09:28 +0200)
The uses of "rcu_assign_pointer()" are NULLing out the pointers.
According to RCU_INIT_POINTER()'s block comment:
"1.   This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.

The following Coccinelle semantic patch was used:
@@
@@

- rcu_assign_pointer
+ RCU_INIT_POINTER
  (..., NULL)

Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Acked-by: Vasu Dev <vasu.dev@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/libfc/fc_libfc.c

index 8d65a51a7598dad8d0a93d326108f0e8a4edfa73..c11a638f32e6dbc3860bad5758fba5e20a9cc562 100644 (file)
@@ -296,9 +296,9 @@ void fc_fc4_deregister_provider(enum fc_fh_type type, struct fc4_prov *prov)
        BUG_ON(type >= FC_FC4_PROV_SIZE);
        mutex_lock(&fc_prov_mutex);
        if (prov->recv)
-               rcu_assign_pointer(fc_passive_prov[type], NULL);
+               RCU_INIT_POINTER(fc_passive_prov[type], NULL);
        else
-               rcu_assign_pointer(fc_active_prov[type], NULL);
+               RCU_INIT_POINTER(fc_active_prov[type], NULL);
        mutex_unlock(&fc_prov_mutex);
        synchronize_rcu();
 }