isdn: cleanup: make buffer smaller
authorDan Carpenter <error27@gmail.com>
Sat, 4 Sep 2010 08:33:03 +0000 (08:33 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Sep 2010 01:29:19 +0000 (18:29 -0700)
This showed up in my audit because we use strcpy() to copy "ds" into a
32 character buffer inside the isdn_tty_dial() function.  But it turns
out that we only ever use the first 32 characters so it's OK.  I have
changed the declaration to make the static checkers happy.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/i4l/isdn_tty.c

index 51dc60da333bcf17cadca7554283b60ce98b21d7..f013ee15327c65a23ca0fc4f5091f70bfd654610 100644 (file)
@@ -3515,7 +3515,7 @@ isdn_tty_parse_at(modem_info * info)
 {
        atemu *m = &info->emu;
        char *p;
-       char ds[40];
+       char ds[ISDN_MSNLEN];
 
 #ifdef ISDN_DEBUG_AT
        printk(KERN_DEBUG "AT: '%s'\n", m->mdmcmd);
@@ -3594,7 +3594,7 @@ isdn_tty_parse_at(modem_info * info)
                                                break;
                                        case '3':
                                                 p++;
-                                                sprintf(ds, "\r\n%d", info->emu.charge);
+                                                snprintf(ds, sizeof(ds), "\r\n%d", info->emu.charge);
                                                 isdn_tty_at_cout(ds, info);
                                                 break;
                                        default:;