staging/rdma/hfi1: Split multiple assignments
authorJubin John <jubin.john@intel.com>
Mon, 15 Feb 2016 04:20:50 +0000 (20:20 -0800)
committerDoug Ledford <dledford@redhat.com>
Fri, 11 Mar 2016 01:45:39 +0000 (20:45 -0500)
Split multiple assignments into individual assignments to fix
checkpatch check:
CHECK: multiple assignments should be avoided

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Jubin John <jubin.john@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/staging/rdma/hfi1/chip.c
drivers/staging/rdma/hfi1/mad.c
drivers/staging/rdma/hfi1/sdma.h

index bdc561087a513b48d4769fb8349c87d3a709fc6d..233958d8061d587dcc9b024378ff7f3e6fab7385 100644 (file)
@@ -12459,8 +12459,10 @@ static int request_msix_irqs(struct hfi1_devdata *dd)
 
        /* calculate the ranges we are going to use */
        first_general = 0;
-       first_sdma = last_general = first_general + 1;
-       first_rx = last_sdma = first_sdma + dd->num_sdma;
+       last_general = first_general + 1;
+       first_sdma = last_general;
+       last_sdma = first_sdma + dd->num_sdma;
+       first_rx = last_sdma;
        last_rx = first_rx + dd->n_krcv_queues;
 
        /*
index 36bd6faeadf4427200aea371537b3f1989763f02..118a09e6ff7e3c28088e4a6d2cf6df537fe53ca2 100644 (file)
@@ -896,8 +896,8 @@ static int port_states_transition_allowed(struct hfi1_pportdata *ppd,
        u32 logical_old = driver_logical_state(ppd);
        int ret, logical_allowed, physical_allowed;
 
-       logical_allowed = ret =
-               logical_transition_allowed(logical_old, logical_new);
+       ret = logical_transition_allowed(logical_old, logical_new);
+       logical_allowed = ret;
 
        if (ret == HFI_TRANSITION_DISALLOWED ||
            ret == HFI_TRANSITION_UNDEFINED) {
@@ -907,8 +907,8 @@ static int port_states_transition_allowed(struct hfi1_pportdata *ppd,
                return ret;
        }
 
-       physical_allowed = ret =
-               physical_transition_allowed(physical_old, physical_new);
+       ret = physical_transition_allowed(physical_old, physical_new);
+       physical_allowed = ret;
 
        if (ret == HFI_TRANSITION_DISALLOWED ||
            ret == HFI_TRANSITION_UNDEFINED) {
index 0ee22c4c5ce17727e45b0810847d2b5c0d5f10f6..0c5f501ee937bf65d9d598dcbc76ec5f6501806e 100644 (file)
@@ -565,7 +565,8 @@ static inline int sdma_txinit_ahg(
        tx->complete = cb;
        tx->coalesce_buf = NULL;
        tx->wait = NULL;
-       tx->tlen = tx->packet_len = tlen;
+       tx->packet_len = tlen;
+       tx->tlen = tx->packet_len;
        tx->descs[0].qw[0] = SDMA_DESC0_FIRST_DESC_FLAG;
        tx->descs[0].qw[1] = 0;
        if (flags & SDMA_TXREQ_F_AHG_COPY)