ext4: Make sure ext4_dirty_inode() updates the inode in no journal mode
authorCurt Wohlgemuth <curtw@google.com>
Tue, 29 Sep 2009 20:06:01 +0000 (16:06 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 29 Sep 2009 20:06:01 +0000 (16:06 -0400)
This patch a problem that ext4_dirty_inode() was not calling
ext4_mark_inode_dirty() if the current_handle is not valid, which it
is the case in no journal mode.

It also removes a test for non-matching transaction which can never
happen.

Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/inode.c

index 22fb1a3a045cb43746a37415efe2f8ce51f6eb90..ec367bce7215a4f0a1dca7abde474617c61fba5b 100644 (file)
@@ -5615,24 +5615,13 @@ void ext4_dirty_inode(struct inode *inode)
        handle_t *current_handle = ext4_journal_current_handle();
        handle_t *handle;
 
-       if (!ext4_handle_valid(current_handle)) {
-               ext4_mark_inode_dirty(current_handle, inode);
-               return;
-       }
-
        handle = ext4_journal_start(inode, 2);
        if (IS_ERR(handle))
                goto out;
-       if (current_handle &&
-               current_handle->h_transaction != handle->h_transaction) {
-               /* This task has a transaction open against a different fs */
-               printk(KERN_EMERG "%s: transactions do not match!\n",
-                      __func__);
-       } else {
-               jbd_debug(5, "marking dirty.  outer handle=%p\n",
-                               current_handle);
-               ext4_mark_inode_dirty(handle, inode);
-       }
+
+       jbd_debug(5, "marking dirty.  outer handle=%p\n", current_handle);
+       ext4_mark_inode_dirty(handle, inode);
+
        ext4_journal_stop(handle);
 out:
        return;