USB: opticon: remove redundant bulk urb fill
authorJohan Hovold <jhovold@gmail.com>
Sun, 18 Nov 2012 12:23:21 +0000 (13:23 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Nov 2012 21:33:54 +0000 (13:33 -0800)
The private bulk in urb is set up at open and does not need to be
reinitialised at every resubmit.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/opticon.c

index 6aba731d4864457acba4e644b463a5c2f725dfc7..cb8674ec5fbbf379f4c789653ee609dd5d14533f 100644 (file)
@@ -135,11 +135,6 @@ exit:
 
        /* Continue trying to always read if we should */
        if (!priv->throttled) {
-               usb_fill_bulk_urb(priv->bulk_read_urb, priv->udev,
-                                 usb_rcvbulkpipe(priv->udev,
-                                                 priv->bulk_address),
-                                 priv->bulk_in_buffer, priv->buffer_size,
-                                 opticon_read_bulk_callback, priv);
                result = usb_submit_urb(priv->bulk_read_urb, GFP_ATOMIC);
                if (result)
                        dev_err(&port->dev,