drm/atomic: Delete an unnecessary check before drm_property_unreference_blob()
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 20 Jul 2016 15:54:32 +0000 (17:54 +0200)
committerSean Paul <seanpaul@chromium.org>
Wed, 20 Jul 2016 17:23:39 +0000 (13:23 -0400)
The drm_property_unreference_blob() function tests whether its argument
is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: http://patchwork.freedesktop.org/patch/msgid/aa4cd508-38c3-78d7-a9f2-70e3b06a8fb5@users.sourceforge.net
drivers/gpu/drm/drm_atomic.c

index 3cee084e9d28efbefb203e3b78491084851ff153..8d2f111fa113363e83218f641f677435b7da832b 100644 (file)
@@ -404,8 +404,7 @@ drm_atomic_replace_property_blob(struct drm_property_blob **blob,
        if (old_blob == new_blob)
                return;
 
-       if (old_blob)
-               drm_property_unreference_blob(old_blob);
+       drm_property_unreference_blob(old_blob);
        if (new_blob)
                drm_property_reference_blob(new_blob);
        *blob = new_blob;