V4L/DVB (10148): cx23885: unsigned cx23417_mailbox cannot be negative

Unsigned cx23417_mailbox cannot be negative

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/video/cx23885/cx23885-417.c b/drivers/media/video/cx23885/cx23885-417.c
index d9888136255da5159bb788ad30a91fb8447ccd79..8f1db57bd1dd8cefc4fcd7b55865429ec04491bd 100644 (file)
--- a/drivers/media/video/cx23885/cx23885-417.c
+++ b/drivers/media/video/cx23885/cx23885-417.c
@@ -1027,12 +1027,13 @@ static int cx23885_initialize_codec(struct cx23885_dev *dev)
                        printk(KERN_ERR "%s() f/w load failed\n", __func__);
                        return retval;
                }
-               dev->cx23417_mailbox = cx23885_find_mailbox(dev);
-               if (dev->cx23417_mailbox < 0) {
+               retval = cx23885_find_mailbox(dev);
+               if (retval < 0) {
                        printk(KERN_ERR "%s() mailbox < 0, error\n",
                                __func__);
                        return -1;
                }
+               dev->cx23417_mailbox = retval;
                retval = cx23885_api_cmd(dev, CX2341X_ENC_PING_FW, 0, 0);
                if (retval < 0) {
                        printk(KERN_ERR