manta: libcamera2: fix copy-and-paste regression
authorMark Salyzyn <salyzyn@google.com>
Fri, 16 Jan 2015 20:27:52 +0000 (12:27 -0800)
committerMark Salyzyn <salyzyn@google.com>
Fri, 16 Jan 2015 20:27:52 +0000 (12:27 -0800)
In "manta: libcamera2: if captured shot drained, record current shot data"
m_reprocessingFrameCnt was taken from previous fragment and not replaced
in the new context with shot_ext->shot.ctl.request.frameCount. This resulted
in CTS:android.hardware.cts.CameraTest@testJpegExif failures.

Bug: 18958123
Change-Id: I3e55fe5be64e2fbc15e14c34891b26afbdb52640

libcamera2/ExynosCameraHWInterface2.cpp

index cead7394757252ed0d6a5b26d1b4bce21f2ae5ed..fa6c8d39c62ce4531e62600327c76ceac17890e4 100644 (file)
@@ -3529,7 +3529,8 @@ void ExynosCameraHWInterface2::m_sensorThreadFunc(SignalDrivenThread * self)
                 if (shot_ext->shot.ctl.request.outputStreams[0] & STREAM_MASK_JPEG) {
                     void *shot = shot_ext;
                     if (m_ctlInfo.flash.m_flashCnt < IS_FLASH_STATE_CAPTURE) {
-                        shot = m_requestManager->GetInternalShotExtByFrameCnt(m_reprocessingFrameCnt);
+                        shot = m_requestManager->GetInternalShotExtByFrameCnt(
+                            shot_ext->shot.ctl.request.frameCount);
                         if (!shot) { // m_isRequestQueueNull reuse current
                             ALOGD("(%s): request_scc: "
                                 "m_reprocessingFrameCnt missing, using shot_ext",