dma: mmp: simplify use of devm_ioremap_resource
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 14 Aug 2013 09:11:11 +0000 (11:11 +0200)
committerVinod Koul <vinod.koul@intel.com>
Wed, 14 Aug 2013 09:21:28 +0000 (14:51 +0530)
Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/mmp_pdma.c
drivers/dma/mmp_tdma.c

index dba9fe9cbbbef30b9392de69913bdb0d1bc9e55f..5c4318c5a5b1e42b47d6e0917a26fdd7a265b485 100644 (file)
@@ -843,9 +843,6 @@ static int mmp_pdma_probe(struct platform_device *op)
        spin_lock_init(&pdev->phy_lock);
 
        iores = platform_get_resource(op, IORESOURCE_MEM, 0);
-       if (!iores)
-               return -EINVAL;
-
        pdev->base = devm_ioremap_resource(pdev->dev, iores);
        if (IS_ERR(pdev->base))
                return PTR_ERR(pdev->base);
index a9345d0387d8fa478f72dbea65bfcfb717f1b191..38cb517fb2ebd82034b02e2ab7d5cabfc9992cbd 100644 (file)
@@ -550,9 +550,6 @@ static int mmp_tdma_probe(struct platform_device *pdev)
        }
 
        iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!iores)
-               return -EINVAL;
-
        tdev->base = devm_ioremap_resource(&pdev->dev, iores);
        if (IS_ERR(tdev->base))
                return PTR_ERR(tdev->base);