[media] media: davinci: vpif_display: return -ENODATA for *std calls
authorLad, Prabhakar <prabhakar.csengg@gmail.com>
Fri, 16 May 2014 13:33:28 +0000 (10:33 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Fri, 23 May 2014 22:16:19 +0000 (19:16 -0300)
this patch adds supports to return -ENODATA to *std calls
if the selected output does not support it.

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/platform/davinci/vpif_display.c

index f51b5bed23bf6c5f5170ccca444432afb1b10b2e..f581e7a1c279c4002a9ea5bd7a8a42bc6333d408 100644 (file)
@@ -715,14 +715,26 @@ static int vpif_try_fmt_vid_out(struct file *file, void *priv,
 
 static int vpif_s_std(struct file *file, void *priv, v4l2_std_id std_id)
 {
+       struct vpif_display_config *config = vpif_dev->platform_data;
        struct video_device *vdev = video_devdata(file);
        struct channel_obj *ch = video_get_drvdata(vdev);
        struct common_obj *common = &ch->common[VPIF_VIDEO_INDEX];
-       int ret = 0;
+       struct vpif_display_chan_config *chan_cfg;
+       struct v4l2_output output;
+       int ret;
+
+       if (config->chan_config[ch->channel_id].outputs == NULL)
+               return -ENODATA;
+
+       chan_cfg = &config->chan_config[ch->channel_id];
+       output = chan_cfg->outputs[ch->output_idx].output;
+       if (output.capabilities != V4L2_OUT_CAP_STD)
+               return -ENODATA;
 
        if (vb2_is_busy(&common->buffer_queue))
                return -EBUSY;
 
+
        if (!(std_id & VPIF_V4L2_STD))
                return -EINVAL;
 
@@ -754,8 +766,19 @@ static int vpif_s_std(struct file *file, void *priv, v4l2_std_id std_id)
 
 static int vpif_g_std(struct file *file, void *priv, v4l2_std_id *std)
 {
+       struct vpif_display_config *config = vpif_dev->platform_data;
        struct video_device *vdev = video_devdata(file);
        struct channel_obj *ch = video_get_drvdata(vdev);
+       struct vpif_display_chan_config *chan_cfg;
+       struct v4l2_output output;
+
+       if (config->chan_config[ch->channel_id].outputs == NULL)
+               return -ENODATA;
+
+       chan_cfg = &config->chan_config[ch->channel_id];
+       output = chan_cfg->outputs[ch->output_idx].output;
+       if (output.capabilities != V4L2_OUT_CAP_STD)
+               return -ENODATA;
 
        *std = ch->video.stdid;
        return 0;