Staging: SLICOSS: Call pci_release_regions at driver exit
authorLior Dotan <liodot@gmail.com>
Wed, 8 Oct 2008 09:37:37 +0000 (11:37 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 10 Oct 2008 22:31:14 +0000 (15:31 -0700)
slic_entry_probe() calls pci_request_regions() but there's no matching
pci_release_regions() at driver's exit or if slic_entry_probe() fails.

Signed-off-by: Lior Dotan <liodot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/slicoss/slicoss.c

index c129e83e2f4ecb45098216e87e38d2cf80cba7f0..b61ac4b2db9e1cc3f4b72ae081f442cc94790ee2 100644 (file)
@@ -520,6 +520,7 @@ err_out_free_mmio_region:
        release_mem_region(mmio_start, mmio_len);
 
 err_out_exit_slic_probe:
+       pci_release_regions(pcidev);
        DBG_ERROR("%s EXIT jiffies[%lx] cpu %d\n", __func__, jiffies,
                  smp_processor_id());
 
@@ -649,6 +650,7 @@ static void __devexit slic_entry_remove(struct pci_dev *pcidev)
        }
        DBG_MSG("slicoss: %s deallocate device\n", __func__);
        kfree(dev);
+       pci_release_regions(pcidev);
        DBG_MSG("slicoss: %s EXIT\n", __func__);
 }