[media] dib9000: fix potential format string leak
authorKees Cook <keescook@chromium.org>
Mon, 30 Sep 2013 16:22:20 +0000 (13:22 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Wed, 2 Oct 2013 09:48:14 +0000 (06:48 -0300)
Make sure that a format string cannot accidentally
leak into the printk buffer.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/dvb-frontends/dib9000.c

index 6201c59a78dd6ad24de4b27ee191b79c4aafdab7..61b2cfe6789c9763913d515f53f447945ab8f5f6 100644 (file)
@@ -649,7 +649,7 @@ static int dib9000_risc_debug_buf(struct dib9000_state *state, u16 * data, u8 si
        b[2 * (size - 2) - 1] = '\0';   /* Bullet proof the buffer */
        if (*b == '~') {
                b++;
-               dprintk(b);
+               dprintk("%s", b);
        } else
                dprintk("RISC%d: %d.%04d %s", state->fe_id, ts / 10000, ts % 10000, *b ? b : "<emtpy>");
        return 1;