netxen: No need to check vfree() pointer.
authorFigo.zhang <figo1802@gmail.com>
Thu, 11 Jun 2009 09:49:10 +0000 (02:49 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Jun 2009 09:49:10 +0000 (02:49 -0700)
vfree() does its own 'NULL' check, so no need for check before
calling it.

Signed-off-by: Figo.zhang <figo1802@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/netxen/netxen_nic_init.c

index 4a51c31330da7aabcab399a0a9a9a9a7076381c5..6f77ad58e3b3d00752861b9626a95493041cbf22 100644 (file)
@@ -178,10 +178,8 @@ void netxen_free_sw_resources(struct netxen_adapter *adapter)
 
        for (ring = 0; ring < adapter->max_rds_rings; ring++) {
                rds_ring = &recv_ctx->rds_rings[ring];
-               if (rds_ring->rx_buf_arr) {
-                       vfree(rds_ring->rx_buf_arr);
-                       rds_ring->rx_buf_arr = NULL;
-               }
+               vfree(rds_ring->rx_buf_arr);
+               rds_ring->rx_buf_arr = NULL;
        }
        kfree(recv_ctx->rds_rings);
 
@@ -190,8 +188,7 @@ skip_rds:
                return;
 
        tx_ring = adapter->tx_ring;
-       if (tx_ring->cmd_buf_arr)
-               vfree(tx_ring->cmd_buf_arr);
+       vfree(tx_ring->cmd_buf_arr);
 }
 
 int netxen_alloc_sw_resources(struct netxen_adapter *adapter)