projects
/
GitHub
/
LineageOS
/
android_kernel_motorola_exynos9610.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c85a1f9
)
virtio-blk: fix NULL checking in virtblk_alloc_req()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Wed, 5 Sep 2012 12:32:53 +0000
(15:32 +0300)
committer
Rusty Russell
<rusty@rustcorp.com.au>
Fri, 28 Sep 2012 05:35:14 +0000
(15:05 +0930)
Smatch complains about the inconsistent NULL checking here. Fix it to
return NULL on failure.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (fixed accidental deletion)
drivers/block/virtio_blk.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/block/virtio_blk.c
b/drivers/block/virtio_blk.c
index 2edfb5cef4f2126631ee42f1dcd5f0d55e08313b..53b81d59059b5d4074b582aab6432ccdba42e79b 100644
(file)
--- a/
drivers/block/virtio_blk.c
+++ b/
drivers/block/virtio_blk.c
@@
-90,10
+90,12
@@
static inline struct virtblk_req *virtblk_alloc_req(struct virtio_blk *vblk,
struct virtblk_req *vbr;
vbr = mempool_alloc(vblk->pool, gfp_mask);
- if (
vbr && use_bio
)
-
sg_init_table(vbr->sg, vblk->sg_elems)
;
+ if (
!vbr
)
+
return NULL
;
vbr->vblk = vblk;
+ if (use_bio)
+ sg_init_table(vbr->sg, vblk->sg_elems);
return vbr;
}