projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: e3d6f90)
target: Fix double test of inquiry_prod
authorRoland Dreier <roland@purestorage.com>
Tue, 3 May 2011 05:15:37 +0000 (22:15 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 22 Jul 2011 09:37:43 +0000 (09:37 +0000)
The code in transport_add_device_to_core_hba() really intends to make sure
that neither inquiry_prod nor inquiry_rev is NULL.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_transport.c patch | blob | blame | history

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index e4406c9e66e0ea884870cb160a8c611ff05fed70..6f5d4dfa14e89f315f523dce0505d19ad1bb9690 100644 (file)
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -1623,7 +1623,7 @@ struct se_device *transport_add_device_to_core_hba(
         * setup.
         */
        if (dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV) {
-               if (!(inquiry_prod) || !(inquiry_prod)) {
+               if (!inquiry_prod || !inquiry_rev) {
                        printk(KERN_ERR "All non TCM/pSCSI plugins require"
                                " INQUIRY consts\n");
                        goto out;