crypto: hash - Fix page length clamping in hash walk
authorHerbert Xu <herbert@gondor.apana.org.au>
Wed, 4 May 2016 09:52:56 +0000 (17:52 +0800)
committerWilly Tarreau <w@1wt.eu>
Tue, 7 Jun 2016 08:42:53 +0000 (10:42 +0200)
commit 13f4bb78cf6a312bbdec367ba3da044b09bf0e29 upstream.

The crypto hash walk code is broken when supplied with an offset
greater than or equal to PAGE_SIZE.  This patch fixes it by adjusting
walk->pg and walk->offset when this happens.

Cc: <stable@vger.kernel.org>
Reported-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Willy Tarreau <w@1wt.eu>
crypto/ahash.c

index 857ae2b2a2a2916e9200431eca6538d6cc39fca5..bcd5efc7eb4c2d6690312d2d4e4929ae07819b32 100644 (file)
@@ -64,8 +64,9 @@ static int hash_walk_new_entry(struct crypto_hash_walk *walk)
        struct scatterlist *sg;
 
        sg = walk->sg;
-       walk->pg = sg_page(sg);
        walk->offset = sg->offset;
+       walk->pg = sg_page(walk->sg) + (walk->offset >> PAGE_SHIFT);
+       walk->offset = offset_in_page(walk->offset);
        walk->entrylen = sg->length;
 
        if (walk->entrylen > walk->total)