[ARM] 5115/1: pxafb: fix ifdef for command line option handling
authorJaya Kumar <jayakumar.arm@gmail.com>
Sun, 22 Jun 2008 03:27:25 +0000 (04:27 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Sun, 22 Jun 2008 13:31:30 +0000 (14:31 +0100)
This bug was found and fixed by Lothar Wassmann.

Previously, the use of ifndef CONFIG_MODULES made it such that pxafb command
line option parsing was dependent on whether the kernel was built with module
support. The ifndef should be MODULE so that parsing is dependent only on
whether the driver is built-in or not.

Signed-off-by: Jaya Kumar <jayakumar.lkml@gmail.com>
Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Acked-by: Eric Miao <eric.miao@marvell.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
drivers/video/pxafb.c

index 7dcda187d9ba363e777f060c757b7c1c05bc7db4..eb23d1923332e02a717582d66b99fd6538261d9b 100644 (file)
@@ -1588,7 +1588,7 @@ static int __init pxafb_parse_options(struct device *dev, char *options)
 
 static char g_options[256] __devinitdata = "";
 
-#ifndef CONFIG_MODULES
+#ifndef MODULE
 static int __devinit pxafb_setup_options(void)
 {
        char *options = NULL;